Page MenuHomeFreeBSD

graphics/imv: Update to 4.2.0
ClosedPublic

Authored by eduardo on Mar 31 2021, 9:14 AM.

Details

Summary
graphics/imv: Update to 4.2.0

ChangeLog: https://github.com/eXeC64/imv/blob/v4.2.0/CHANGELOG

Reviewed by:	mat
Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D29508
Test Plan
$ portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.

poudriere testport logs:

140amd64
140i386
130amd64
130i386
122amd64
122i386
114amd64
114i386

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

eduardo edited the summary of this revision. (Show Details)

Changes look good to me, but ports repository is being converted to git right now. Lets wait the new repository to be open for commits and then you can update the patch using git.

git diff:
git diff -U999999 . > imv.diff

Use _MESON_ENABLED instead of _MESON_ON/OFF

Can't use _MESON_ENABLED for windows option:
"meson.build:1:0: ERROR: Value "x11=disabled" (of type "string") for combo option "window system to use" is not one of the choices. Possible choices are (as string): "all", "wayland", "x11"."

graphics/imv/Makefile
80–93

I think you can't have two -Dwindows= args:
https://github.com/eXeC64/imv/blob/master/meson.build#L25-L38

Maybe the better approach is using OPTIONS SINGLE here.

move "Windowing system" port option from multi to single option.

move "Windowing system" port option from multi to single option.

Nice.

I did some tests as well:

====> Windowing system: you have to select exactly one of them
     WAYLAND=on: Wayland (graphics) support
     X11=off: X11 (graphics) support
     ALL=off
ok
====> Windowing system: you have to select exactly one of them
     WAYLAND=off: Wayland (graphics) support
     X11=on: X11 (graphics) support
     ALL=off

ok
====> Windowing system: you have to select exactly one of them
     WAYLAND=off: Wayland (graphics) support
     X11=off: X11 (graphics) support
     ALL=on

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/imv-wayland is linked to /usr/local/lib/libwayland-client.so.0 from graphics/wayland but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libwayland-client.so:graphics/wayland
Error: /usr/local/bin/imv-wayland is linked to /usr/local/lib/libwayland-egl.so.1 from graphics/wayland but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libwayland-egl.so:graphics/wayland

Final adjustments, add WAYLAND_LIB_DEPENDS to the ALL option as well.

eduardo marked an inline comment as done.
eduardo edited the test plan for this revision. (Show Details)
  • add missing wayland dependency to ALL "Windowing system" option
  • refreshed poudriere testport logs

Good job.
Don't forget to give credits to mat@ for the review in the commit message.

This revision is now accepted and ready to land.Tue, Apr 27, 11:17 AM

Thanks mat and my mentors dbaio and garga!

graphics/imv/Makefile
80–93

According to https://github.com/eXeC64/imv/blob/master/meson_options.txt,
we can have both wayland and x11 selected that is equal to -Dwindows=all

graphics/imv/files/patch-meson.build
7–8
This revision was automatically updated to reflect the committed changes.