Page MenuHomeFreeBSD

devel/git, devel/git-cvs, and 2 more: Split git ports
AbandonedPublic

Authored by grembo on May 13 2021, 2:49 AM.

Details

Reviewers
garga
Summary

This moves CVS, P4, and SVN support to three subports,
so that they're not built by default, but can be installed
as binary packages that depend on devel/git.

Things were done in a way, so that the port can be
maintained from within devel/git.

Did some testing, could use some more love.

Test Plan

Made sure things build. Only minimal test if p4, svn,
and cvs still work (nothing to check with).

Ran these poudriere tests successfully (using default options):

  • poudriere testport -j122amd64 devel/git@tiny
  • poudriere testport -j122amd64 devel/git@lite
  • poudriere testport -j122amd64 devel/git
  • poudriere testport -j122amd64 devel/git-cvs
  • poudriere testport -j122amd64 devel/git-p4
  • poudriere testport -j122amd64 devel/git-svn

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 40225
Build 37114: arc lint + arc unit

Event Timeline

Minor changes. It's a bit ugly how options are defined and excluded right now,
but it works well enough for someone (hopefully) take it from there.

Put some more effort into this...

grembo added a reviewer: garga.
grembo changed the repository for this revision from rP FreeBSD ports repository to R11 FreeBSD ports repository.
grembo added a subscriber: swills.
grembo edited the test plan for this revision. (Show Details)

Use contemporary terminology

Looks OK to me. It is as you say a bit ugly, but I think it gets us where we want to be and is the best we can do until sub-packages are supported.

I won't have the time to work on it until next week, but I like the idea

I won't have the time to work on it until next week, but I like the idea

Any news, anything I can do to help?

I won't have the time to work on it until next week, but I like the idea

Any news, anything I can do to help?

I'm facing some issues on the system I use to test all my ports related stuff. Hopefully it will be fixed today yet and then I'm going to be able to test it and get it committed.

@grembo Patch is not applying after latest changes on git port. Could you please rebase it? I finally found the time to work on it, sorry for the delay

@grembo Patch is not applying after latest changes on git port. Could you please rebase it? I finally found the time to work on it, sorry for the delay

Should apply now (there were a couple of bigger changes to the port just two days ago, so it was a bit of work to get it back in line). I tested git/git-p4/git-cvs in poudriere testport, git-svn is still running as it takes forever (lots of dependencies, including cmake).

Once this is done, we might consider turning git-lite into git-core and base the git port on it (that way, git-core/lite could become a meaningful port to depend on). But that's some future business. For now, let's focus on landing this change, which should already improve the situation for folks like @bdrewery who need an easy/painless way to have git-svn support.

@garga There is a MOVED entry on git-cvs, seems like there was something python based of that name before. So you would need to take care of this to allow the port to build in bulk (non-testport) mode.

@garga There is a MOVED entry on git-cvs, seems like there was something python based of that name before. So you would need to take care of this to allow the port to build in bulk (non-testport) mode.

@garga ping?

@garga There is a MOVED entry on git-cvs, seems like there was something python based of that name before. So you would need to take care of this to allow the port to build in bulk (non-testport) mode.

@garga ping?

Hello! I'm working on it and making more changes to create more sub packages and make it as much flexible as I can. Unfortunately I don't have lots of free hours as I would like but I'm on it and don't plan to make any other changes on this port before this one

garga resigned from this revision.EditedOct 8 2021, 3:24 PM

@grembo I've submitted a new review https://reviews.freebsd.org/D32369 with final changes I made during tests and also with new git-gui subpackage. Thank you!

D32369 landed in https://cgit.freebsd.org/ports/commit/devel/git?id=ff5ded75bcda28c580623504e01f5db8eb6be9cf

Abandoning, as closing isn't an option at this point. Very happy it made it to the tree.