Page MenuHomeFreeBSD

www/pear-HTTP_Request2: Import fix from upstream
ClosedPublic

Authored by garga on Jul 2 2021, 1:58 PM.

Details

Summary

pfSense users reported a communication error on code that uses
HTTP_Request2 after we moved to most recent version. After
reporting the issue to upstream they came up with a fix that
confirmed working.

This change adds upstream fix and while here, I also changed
USES order to make portlint happy and added LICENSE.

[1] https://redmine.pfsense.org/issues/12048

Obtained from: pfSense
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

garga requested review of this revision.Jul 2 2021, 1:58 PM

Another perhaps slightly neater alternative solution

PATCH_SITES=	https://github.com/pear/${PORTNAME}/commit/
PATCHFILES=	63e6f932ab4004f0c09a080d370861d0323b6d33.patch:-p1
This revision is now accepted and ready to land.Jul 10 2021, 1:55 PM
In D31000#697770, @daniel.engberg.lists_pyret.net wrote:

Another perhaps slightly neater alternative solution

PATCH_SITES=	https://github.com/pear/${PORTNAME}/commit/
PATCHFILES=	63e6f932ab4004f0c09a080d370861d0323b6d33.patch:-p1

I do not like this way because I have encountered the problem that the commit is missing upstream.
But I'd put the link to upstream commit/issue/pr into the patch file.