Page MenuHomeFreeBSD

graphics/imv: allow building on Wayland-only
ClosedPublic

Authored by eduardo on Tue, Jun 8, 9:54 AM.

Details

Summary
graphics/imv: allow building on Wayland-only

imv can work on a system where libX11 is fully removed
and OpenGL is provided by libOpenGL instead of libGL[1].

USE_GL=gl implies lib-depends on libGL, which is built
only when X11 symbols are available, which is not always
the case.

libglvnd provides libOpenGL which provides OpenGL
symbols without X11 symbols.

To satisfy poudriere testport, do USE_GL=egl because
there is no libOpenGL handling in Mk/Uses/gl.mk currently.

libEGL is supposed to always exist per pkg-plist of mesa-*.

Adjust USE_GL for imv to build on global X11=off XCB=off XLIB=off.

[1]: https://github.com/eXeC64/imv/commit/
70a70727b74c532ffb303023b3eb215310948b31

Rebased version is always available here:
https://codeberg.org/ei/ports/commits/branch/ei

PR:		256419
Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D30694
Test Plan

poudriere testport with libglvnd, X11=off and ALL: OK
make -V USE_GL overall sanity: OK

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

eduardo created this revision.
This revision is now accepted and ready to land.Wed, Jun 9, 1:49 AM

Should I bump PORTREVISION?

In my opinion, yes. Other than that patch looks fine

This revision now requires review to proceed.Thu, Jun 10, 6:44 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jun 10, 6:48 AM
This revision was automatically updated to reflect the committed changes.