Do you intent to commit this immediately, or later?

LGTM, accepted contingent on poudriere passing

These comments are applicable for the non-release version of pylibacl; pylibacl 0.5.4 supports 2.7 and doesn't support pytest: https://github.com/iustin/pylibacl/blob/pylibacl-v0.5.4/.travis.yml .

When the next version is released, the changes you requested should definitely be implemented.

• Please confirm portlint and poudriere (Py 2.x and Py 3.x) pass (ive added bullet points for these in TEST PLAN section)
• 0.5.3 and 0.5.4 are bugfix only releases, with specific FreeBSD bugfixes: MFH: 2010Q1
• Changelog says: Drop support (well, drop testing) for Python lower than 2.7. but setup.py contains python_requires = ">=3.4", which will fail for 2.x. This should be patched out of setup.py and reported upstream. Upstream should add that only when 2.7 is explicitly *not* supported. If upstream says its unsupported now, then port should USES=python:3.4+ accordingly
• Upstream switched from unittest to pytest and setup.py test has technically been deprecated. Switch [2] to:

Looks OK from my limited understanding of the context / semantics of the change. Over to @kai

Hey, meant to follow this up sooner but the last few weeks have been crazy. Shared dependencies are incompatible with the way Python tracks versions. The Python team will be discussing ways to ensure the accuracy of Python port dependencies, which shared/common macros preclude. We're looking to remove the existing ones once we're ready.

Does this need MFH'ing?

Not sure if you can (that would be cool), just add/change the reviewer type after attaching

Add maintainers for non-blanket (not implicitly approved) changes as blocking reviewers, eg: if @bapt and @manu are uboot@.

Approved if MOVEDlint.awk passes and after removing GL_PROJECT=python-crontab (assuming GL_PROJECT defaults to PORTNAME like GH does)

LGTM. Any committer taking this should verify QA (Python 2.x / 3.x and running test target)

Nice!

You can try to use USE_LOCAL=<locale> or TEST_ENV+=LANG=whatever to set a more appropriate locale (the one that tests 'rely' on)

Conversely, there will have and continue to be users that pkg install 'pyyaml' using the name referenced by upstream and in all current and future documentation, and the names used by all packages that depend on it, that dont/cant find it.

Nice review @kevans

@kai You have a deeper understanding of theQA implications and context of these changes. Approved if you're confident and happy and having addressed my prior review comments

If this is a bugfix (reads like it is), then MFH: <quarterly> (blanket: bugfix)

@0mp Thanks for this.

Ack on separate commits

Re removing PORTREVISIONS, we dont ''want'' ports to switch to use pillow6/pillow7 (based on / with new conditionals) after this commit?

It would be good to have an explanation for the unexpected pkg-plist change, assuming its not influenced (confirmed with you on irc) or caused by the reinplace_cmd change

If its possible to make the commit log message more obvious that not fixing this ''will'' be an error after 229925, then do so, but not a dealbreaker

Is there a present or future (upcoming base change for example) impact of not removing the redundant escape? If so, clarify that in commit message

Anything that isn't a version update (unless its a security, bug fix release version update), is a MFH candidate. More precisely, there ought to be a reason (by policy or otherwise) not to MFH something, and in particular, merging things makes future merges easier (as one has to either commit all intervening commits anyway, or do direct to quarterly merges, which can be risky

For ports that have maintainers that have Phabricator accounts, its nice to add them to Reviewers: even if an existing PR exists and even in the case of an implicit/blanket/other approval, as a heads up

Additional changes:

In D23615#518777, @wulf wrote:

In D23615#518766, @koobs wrote:

Fails building in 11amd64 with the following, so will at least set OSVERSION > 12* unless its expected or desirable for iichid to be test on 11:

Only 12.1+ is supported.

11 requires some ig4 and ACPI bits to be MFC-ed.

Fails building in 11amd64 with the following, so will at least set OSVERSION > 12* unless its expected or desirable for iichid to be test on 11:

@imp @wulf This appears to build/package (poudriere) fine on 12amd64, should we leave it open for any version/arch, or should we limit it. If limiting, I need a list of archs for ONLY_FOR_ARCHS and OSVERSIONS we shouldn't set IGNORE for

Landing this today

Just adding review comments for posterity.

I'll help to get this landed in ports and can make the MAINTAINER change if Cy doesn't have cycles