Page MenuHomeFreeBSD

devel/py-watchdog: Update to 0.10.2
ClosedPublic

Authored by github_evilham.com on Feb 10 2020, 6:36 PM.

Details

Summary
devel/py-watchdog: Update to 0.10.2

As a result of improved testing and a hiccup in which 0.10.0 and 0.10.1 didn't support BSD, the 0.10.2 release features better support for BSD in general and specifically also tests against 12.1-RELEASE

Changelog:

  https://github.com/gorakhargosh/watchdog/releases/tag/v0.10.2

PR: 244031
Test Plan
  • Improved upstream's test set and kqueue support
  • Built with poudriere without network
  • Tested watchmedo
  • Tested lektor (also compiled in poudriere with this version)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

koobs requested changes to this revision.Feb 11 2020, 12:52 AM
koobs added a subscriber: koobs.
koobs added inline comments.
devel/py-watchdog/Makefile
7 ↗(On Diff #68084)

Add python as a secondary (virtual) category

20 ↗(On Diff #68084)

Ports SHOULD use MASTER_SITES=CHEESESHOP if a Python package is registered on PyPI, unless there is a compelling (temporary) case not to.

https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

21 ↗(On Diff #68084)

Package provides files in shared (common) locations [1], and must be made concurrent safe (USE_PYTHON=concurrent)

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

[1] entry_points={'console_scripts':

25 ↗(On Diff #68084)

Shouldn't need this with/after USE_PYTHON=concurrent

34 ↗(On Diff #68084)

Add TEST_DEPENDS (pytest) and test (do-test) target if/when a package provides them

Directly invoke pytest (not tox)

This revision now requires changes to proceed.Feb 11 2020, 12:52 AM
github_evilham.com marked 5 inline comments as done.

Thank you for the review, learnt a lot.

Additionally removed PORTREVISION as it wasn't needed and DISTVERSIONPREFIX which was an issue with CHEESESHOP.

koobs requested changes to this revision.Feb 23 2020, 4:01 AM
koobs added inline comments.
devel/py-watchdog/Makefile
41 ↗(On Diff #68110)

Do -m pytest -v -rs -o addopts= here, it overrides current or future pytest.ini setup.cfg:[pytest] settings which can cause test invocation to fail

This revision now requires changes to proceed.Feb 23 2020, 4:01 AM

Sounds good, I checked again that all tests pass. Thank you.

koobs retitled this revision from [PORT UPDATE]: devel/py-watchdog -- improved BSD support upstream to devel/py-watchdog: Update to 0.10.2.Mar 13 2020, 4:22 AM
koobs edited the summary of this revision. (Show Details)
koobs edited the summary of this revision. (Show Details)
koobs removed a subscriber: koobs.

LGTM. Any committer taking this should verify QA (Python 2.x / 3.x and running test target)

This revision is now accepted and ready to land.Mar 13 2020, 4:26 AM
This revision was automatically updated to reflect the committed changes.