Page MenuHomeFreeBSD

[PORT UPDATE]: devel/py-watchdog -- improved BSD support upstream
Needs ReviewPublic

Authored by github_evilham.com on Mon, Feb 10, 6:36 PM.

Details

Reviewers
nivit
koobs
Summary

As a result of improved testing and a hiccup in which 0.10.0 and 0.10.1 didn't support BSD, the latest release features better support for BSD in general and specifically also tests against 12.1-RELEASE

https://github.com/gorakhargosh/watchdog/releases/tag/v0.10.2

Test Plan
  • Improved upstream's test set and kqueue support
  • Built with poudriere without network
  • Tested watchmedo
  • Tested lektor (also compiled in poudriere with this version)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29289
Build 27199: arc lint + arc unit

Event Timeline

Remove unrelated changes.

koobs requested changes to this revision.Tue, Feb 11, 12:52 AM
koobs added a subscriber: koobs.
koobs added inline comments.
devel/py-watchdog/Makefile
4–6

Add python as a secondary (virtual) category

20–21

Ports SHOULD use MASTER_SITES=CHEESESHOP if a Python package is registered on PyPI, unless there is a compelling (temporary) case not to.

https://wiki.freebsd.org/Python/PortsPolicy#MASTER_SITES

21

Package provides files in shared (common) locations [1], and must be made concurrent safe (USE_PYTHON=concurrent)

https://wiki.freebsd.org/Python/PortsPolicy#concurrent

[1] entry_points={'console_scripts':

24–25

Shouldn't need this with/after USE_PYTHON=concurrent

31

Add TEST_DEPENDS (pytest) and test (do-test) target if/when a package provides them

Directly invoke pytest (not tox)

This revision now requires changes to proceed.Tue, Feb 11, 12:52 AM
github_evilham.com marked 5 inline comments as done.

Thank you for the review, learnt a lot.

Additionally removed PORTREVISION as it wasn't needed and DISTVERSIONPREFIX which was an issue with CHEESESHOP.