Page MenuHomeFreeBSD
Differential D22909

net-mgmt/netdata: Detect default version of Python if installed
ClosedPublic
Actions

Authored by diizzy on Dec 23 2019, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 8:30 PM
Unknown Object (File)
Wed, Jan 29, 1:51 PM
Unknown Object (File)
Wed, Jan 29, 10:43 AM
Unknown Object (File)
Fri, Jan 24, 9:23 PM
Unknown Object (File)
Tue, Jan 14, 12:46 PM
Unknown Object (File)
Tue, Jan 14, 12:36 PM
Unknown Object (File)
Tue, Jan 14, 12:34 PM
Unknown Object (File)
Dec 14 2024, 1:38 PM
View All 67 Files
Subscribers
mat
otis

Details

Reviewers
araujo
mmokhi
mat
otis
Commits
rP526347: MFH: r526346 net-mgmt/netdata: Honour/respect default Python version
rP526346: net-mgmt/netdata: Honour/respect default Python version
Summary

Make netdata detect default version of Python

Test Plan

Run-time tested on 13-CURRENT

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

diizzy created this revision.Dec 23 2019, 10:20 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 23 2019, 10:20 AM
otis added a subscriber: otis.Jan 7 2020, 9:13 PM
diizzy added a comment.Jan 12 2020, 12:50 AM

@araujo @mmokhi
Friendly ping

mat added a comment.Jan 15 2020, 8:44 AM

Mmmm, this is doing it wrong. Say, I have installed Python 3.8 to test some stuffs but the default Python is 3.7.
This would have it use Python 3.8 which it should not be doing because it is not the default.

The patch should replace it to pybinary=%%PYTHON%% or something, and then in post-patch, you should replace %%PYTHON%% with ${PYTHON_CMD}.

That way, the correct default Python would always be used.

mat requested changes to this revision.Jan 15 2020, 8:45 AM
This revision now requires changes to proceed.Jan 15 2020, 8:45 AM
diizzy updated this revision to Diff 66775.Jan 15 2020, 11:11 AM
diizzy retitled this revision from net-mgmt/netdata: Detect Python 3.7 and 3.8 if installed to net-mgmt/netdata: Detect default version of Python if installed.
diizzy edited the summary of this revision. (Show Details)

Changed patch upon mat@ suggestions

otis accepted this revision.Jan 15 2020, 12:31 PM

https://pdr1.wilbury.net/data/12_STABLE_amd64-default/2020-01-15_12h18m59s/logs/netdata-1.19.0_1.log

LGTM

diizzy mentioned this in D23195: [NEW PORT] devel/premake5 : Build script creation tool .Jan 15 2020, 10:11 PM
mat requested changes to this revision.Jan 28 2020, 8:51 PM

Please regenerate the patch with make makepatch.

This revision now requires changes to proceed.Jan 28 2020, 8:51 PM
diizzy updated this revision to Diff 67537.Jan 30 2020, 11:28 PM

Refresh patch

mat accepted this revision.Jan 30 2020, 11:37 PM
This revision is now accepted and ready to land.Jan 30 2020, 11:37 PM
Closed by commit rP526346: net-mgmt/netdata: Honour/respect default Python version (authored by koobs). · Explain WhyFeb 17 2020, 6:59 AM
This revision was automatically updated to reflect the committed changes.
koobs added a commit: rP526346: net-mgmt/netdata: Honour/respect default Python version.
koobs added a commit: rP526347: MFH: r526346 net-mgmt/netdata: Honour/respect default Python version.Feb 17 2020, 7:01 AM

Revision Contents
Changeset List

PathSize
head/
net-mgmt/
netdata/
3 lines
files/
6 lines

Diff 68440

View Options

head/net-mgmt/netdata/Makefile

Loading...
View Options

head/net-mgmt/netdata/files/patch-collectors_python.d.plugin_python.d.plugin.in

Loading...