Page MenuHomeFreeBSD

net-mgmt/netdata: Detect default version of Python if installed
ClosedPublic

Authored by daniel.engberg.lists_pyret.net on Dec 23 2019, 10:20 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat added a comment.Jan 15 2020, 8:44 AM

Mmmm, this is doing it wrong. Say, I have installed Python 3.8 to test some stuffs but the default Python is 3.7.
This would have it use Python 3.8 which it should not be doing because it is not the default.

The patch should replace it to pybinary=%%PYTHON%% or something, and then in post-patch, you should replace %%PYTHON%% with ${PYTHON_CMD}.

That way, the correct default Python would always be used.

mat requested changes to this revision.Jan 15 2020, 8:45 AM
This revision now requires changes to proceed.Jan 15 2020, 8:45 AM
daniel.engberg.lists_pyret.net retitled this revision from net-mgmt/netdata: Detect Python 3.7 and 3.8 if installed to net-mgmt/netdata: Detect default version of Python if installed.
daniel.engberg.lists_pyret.net edited the summary of this revision. (Show Details)

Changed patch upon mat@ suggestions

mat requested changes to this revision.Tue, Jan 28, 8:51 PM

Please regenerate the patch with make makepatch.

This revision now requires changes to proceed.Tue, Jan 28, 8:51 PM
mat accepted this revision.Thu, Jan 30, 11:37 PM
This revision is now accepted and ready to land.Thu, Jan 30, 11:37 PM
This revision was automatically updated to reflect the committed changes.