Page MenuHomeFreeBSD

net-mgmt/netdata: Detect default version of Python if installed
ClosedPublic

Authored by diizzy on Dec 23 2019, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 3:44 AM
Unknown Object (File)
Feb 22 2024, 9:45 PM
Unknown Object (File)
Dec 26 2023, 5:36 AM
Unknown Object (File)
Dec 22 2023, 9:51 PM
Unknown Object (File)
Dec 13 2023, 4:56 AM
Unknown Object (File)
Nov 17 2023, 3:04 PM
Unknown Object (File)
Nov 17 2023, 3:02 PM
Unknown Object (File)
Nov 17 2023, 2:52 PM
Subscribers

Details

Summary

Make netdata detect default version of Python

Test Plan

Run-time tested on 13-CURRENT

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Mmmm, this is doing it wrong. Say, I have installed Python 3.8 to test some stuffs but the default Python is 3.7.
This would have it use Python 3.8 which it should not be doing because it is not the default.

The patch should replace it to pybinary=%%PYTHON%% or something, and then in post-patch, you should replace %%PYTHON%% with ${PYTHON_CMD}.

That way, the correct default Python would always be used.

mat requested changes to this revision.Jan 15 2020, 8:45 AM
This revision now requires changes to proceed.Jan 15 2020, 8:45 AM
diizzy retitled this revision from net-mgmt/netdata: Detect Python 3.7 and 3.8 if installed to net-mgmt/netdata: Detect default version of Python if installed.
diizzy edited the summary of this revision. (Show Details)

Changed patch upon mat@ suggestions

mat requested changes to this revision.Jan 28 2020, 8:51 PM

Please regenerate the patch with make makepatch.

This revision now requires changes to proceed.Jan 28 2020, 8:51 PM
This revision is now accepted and ready to land.Jan 30 2020, 11:37 PM