[NEW PORT] devel/premake5 : Build script creation tool

[freebsd_sysctl.cz]

Summary

[NEW PORT] devel/premake5 : Build script creation tool

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241365

[diizzy]

Path is wrong, you're missing one level.

premake5/Makefile

3 ↗

(On Diff #66805)

Use tabs instead of spaces in Makefile for variables, it doesn't run otherwise.
This also seems to affect your patch files.

21 ↗

(On Diff #66805)

GH_TAGNAME isn't needed however upstream suggests that you grab their archive/tarball instead.
https://github.com/premake/premake-core/releases

26 ↗

(On Diff #66805)

Use MAKE_CMD instead of hardcoding GMAKE

premake5/files/patch-Bootstrap.mak

8 ↗

(On Diff #66805)

You might want to consider using a variable instead and patch it in the Makefile rather than hardcoding it.
https://reviews.freebsd.org/D22909 (see the suggestion by mat@)

[freebsd_sysctl.cz]

New version diff file for premake5

[freebsd_sysctl.cz]

Update diff file

[freebsd_sysctl.cz]

Update diff file premake5

[mat]

devel/premake5/Makefile

3

PORTNAME=premake

and later

PKGNAMESUFFIX= 5

5

The commit you are using is not for 5.0.0 but for something called v5.0.0-alpha13.

So you should set:

DISTVERSION= 5.0.0-alpha13

and remove the GH_COMMIT variable.

17

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

20

Remove this.

26–27

MAKEFILE= Bootstrap.mak
ALL_TARGETS= bsd

[mat]

Side not, you should not use USE_GITHUB, upstream is providing distfiles, see https://github.com/premake/premake-core/releases

[freebsd_sysctl.cz]

The premake5 port now is in porttree.Can zou close this review ?