Page MenuHomeFreeBSD

[NEW PORT] devel/premake5 : Build script creation tool
AbandonedPublic

Authored by freebsd_sysctl.cz on Jan 15 2020, 8:26 PM.
Tags
None
Referenced Files
F169867538: D23195.id67376.diff
Wed, Sep 2, 8:16 PM
F169855920: D23195.id67380.diff
Wed, Sep 2, 6:56 PM
F169811946: D23195.diff
Wed, Sep 2, 3:37 PM
F169801041: D23195.id.diff
Wed, Sep 2, 2:55 PM
F169757486: D23195.id67378.diff
Wed, Sep 2, 11:36 AM
F169751998: D23195.id66811.diff
Wed, Sep 2, 11:18 AM
F169751984: D23195.id66810.diff
Wed, Sep 2, 11:18 AM
Unknown Object (File)
Tue, Sep 1, 9:42 PM
Subscribers

Details

Summary

[NEW PORT] devel/premake5 : Build script creation tool

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241365

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

freebsd_sysctl.cz retitled this revision from new version anydesk, change with permision to premake5 .Jan 15 2020, 8:28 PM
freebsd_sysctl.cz edited the summary of this revision. (Show Details)
freebsd_sysctl.cz retitled this revision from premake5 to [NEW PORT] devel/premake5 : Build script creation tool .
freebsd_sysctl.cz edited the summary of this revision. (Show Details)
freebsd_sysctl.cz edited the summary of this revision. (Show Details)

Path is wrong, you're missing one level.

premake5/Makefile
3

Use tabs instead of spaces in Makefile for variables, it doesn't run otherwise.
This also seems to affect your patch files.

21

GH_TAGNAME isn't needed however upstream suggests that you grab their archive/tarball instead.
https://github.com/premake/premake-core/releases

26

Use MAKE_CMD instead of hardcoding GMAKE

premake5/files/patch-Bootstrap.mak
8

You might want to consider using a variable instead and patch it in the Makefile rather than hardcoding it.
https://reviews.freebsd.org/D22909 (see the suggestion by mat@)

New version diff file for premake5

mat added inline comments.
devel/premake5/Makefile
3 ↗(On Diff #67380)
PORTNAME=premake

and later

PKGNAMESUFFIX= 5
5 ↗(On Diff #67380)

The commit you are using is not for 5.0.0 but for something called v5.0.0-alpha13.

So you should set:

DISTVERSION= 5.0.0-alpha13

and remove the GH_COMMIT variable.

17 ↗(On Diff #67380)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

20 ↗(On Diff #67380)

Remove this.

26–27 ↗(On Diff #67380)

MAKEFILE= Bootstrap.mak
ALL_TARGETS= bsd

Side not, you should not use USE_GITHUB, upstream is providing distfiles, see https://github.com/premake/premake-core/releases

The premake5 port now is in porttree.Can zou close this review ?

This revision is now accepted and ready to land.Feb 2 2020, 8:41 AM