Paths

Table of Contentst

Differential D23701

www/p5-Gantry: correctly escape $
ClosedPublic
Actions

Authored by kevans on Feb 15 2020, 8:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 10, 6:35 AM

	Unknown Object (File)
	Fri, May 8, 7:28 PM

	Unknown Object (File)
	Sat, May 2, 3:10 AM

	Unknown Object (File)
	Thu, Apr 30, 8:17 AM

	Unknown Object (File)
	Thu, Apr 30, 4:51 AM

	Unknown Object (File)
	Thu, Apr 30, 4:51 AM

	Unknown Object (File)
	Sun, Apr 26, 4:48 PM

	Unknown Object (File)
	Sun, Apr 26, 5:36 AM

Subscribers

Details

Reviewers

bapt
koobs

Group Reviewers

Commits

rP526605: MFH: r526604
rP526604: www/p5-Gantry: correctly escape $

Summary

www/p5-Gantry: correctly escape $

In make(1), "$$" is the escaped version of "$", rather than the expected "\$". this expression was getting passed through to ${REINPLACE_CMD} as "s,\NV{..." rathern than the expected "s,$ENV{..." -- bug #229925 makes \N an illegal expression, as ordinary characters will be disallowed from being escaped in preparation for future changes to grant some of these escape sequences GNU-extended behavior.

PR: 240310
Reviewed_by: koobs (mentor), bapt (mentor)
Approved by: koobs (mentor), bapt (mentor)
Approved by: portmgr (maintainer timeout: 4 months, blanket: bugfix)
MFH: 2020Q1 (blanket: bugfix)

Test Plan

Q/A:

testport (12amd64; no build/plist changes)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Feb 15 2020, 8:10 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 15 2020, 8:10 PM

kevans edited the test plan for this revision. (Show Details)Feb 15 2020, 8:10 PM

bapt accepted this revision.Feb 16 2020, 5:03 PM

This revision is now accepted and ready to land.Feb 16 2020, 5:03 PM

koobs edited the summary of this revision. (Show Details)Feb 17 2020, 1:40 AM

kevans added a reviewer: Perl.Feb 17 2020, 1:53 AM

If this is a bugfix (reads like it is), then MFH: <quarterly> (blanket: bugfix)

koobs edited the summary of this revision. (Show Details)Feb 21 2020, 1:42 AM

Closed by commit rP526604: www/p5-Gantry: correctly escape $ (authored by kevans). · Explain WhyFeb 21 2020, 4:01 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rP526604: www/p5-Gantry: correctly escape $.

kevans added a commit: rP526605: MFH: r526604.

Revision Contents
Changeset List

Path

Size

head/

www/

p5-Gantry/

2 lines

Diff 68625

head/www/p5-Gantry/Makefile

Loading...