Page MenuHomeFreeBSD

www/p5-Gantry: correctly escape $
ClosedPublic

Authored by kevans on Feb 15 2020, 8:10 PM.

Details

Summary
www/p5-Gantry: correctly escape $

In make(1), "$$" is the escaped version of "$", rather than the expected "\$". this expression was getting passed through to ${REINPLACE_CMD} as "s,\NV{..." rathern than the expected "s,$ENV{..." -- bug #229925 makes \N an illegal expression, as ordinary characters will be disallowed from being escaped in preparation for future changes to grant some of these escape sequences GNU-extended behavior.

PR: 240310
Reviewed_by: koobs (mentor), bapt (mentor)
Approved by: koobs (mentor), bapt (mentor)
Approved by: portmgr (maintainer timeout: 4 months, blanket: bugfix)
MFH: 2020Q1 (blanket: bugfix)
Test Plan

Q/A:

  • testport (12amd64; no build/plist changes)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Feb 16 2020, 5:03 PM

If this is a bugfix (reads like it is), then MFH: <quarterly> (blanket: bugfix)

This revision was automatically updated to reflect the committed changes.