www/foswiki: remove redundant escape = does not need to be escaped in this context; bug #229925 aims to make escape of most ordinary characters an error to reduce friction when some of these ordinary characters are later granted special GNU-extended behavior. No functional change, no need to bump PORTREVISION. PR: 240309 Approved by: koobs (mentor), portmgr (maintainer timeout: 4 months) Differential_Revision: D23698
- testport (12.0 amd64, -HEAD w/ 229925 applied)
For ports that have maintainers that have Phabricator accounts, its nice to add them to Reviewers: even if an existing PR exists and even in the case of an implicit/blanket/other approval, as a heads up
Anything that isn't a version update (unless its a security, bug fix release version update), is a MFH candidate. More precisely, there ought to be a reason (by policy or otherwise) not to MFH something, and in particular, merging things makes future merges easier (as one has to either commit all intervening commits anyway, or do direct to quarterly merges, which can be risky
Is there a present or future (upcoming base change for example) impact of not removing the redundant escape? If so, clarify that in commit message
make escape of most ordinary characters an error appears to get at the impact, but it wasn't entirely clear, at least to me, whether its theoretical, or whether leaving the escape in place would return an error if not removed, after the relevant base change was commited
Indeed- the implied part of these changes is that they're being made specifically because they are erroneous. I could make others on the basis of correctness, but have opted not to do so for now.