Committed updated version in rP496935

Thank you for the insight @tuexen

Format the review SUMMARY field like a well-formatted commit log message. Primarily that is:

Thank you for this @tuexen!

Looks good, happy for you to proceed if you're comfortable/confident with the changeset.

Syntax changes look ok, please confirm that this change passes QA (I've added items to the TEST PLAN section of this review)

Replace 'elasticache' typo with 'elasticsearch'

Please confirm this also passes portlint

@jhixson Could you please add the full port/diff context to the review please. I'm under the impression arc diff create created full file context unless --less-context was used, so not sure why/how there's no full context here. Maybe its a default config file or something.

Hmm, can't see port contents in the diff, something up with Phabricator?

It's not that 2.7+ is "better", its that :3.6 is "incorrect" in that:

In D18566#399201, @cem wrote:

In D18566#399196, @koobs wrote:

Change looks fine, thanks for commenting/referencing the patches/sources

Happy to accept after confirmation of QA, particularly as this change will be MFH'd.

Thanks Kubilay. As noted in the PR, "It builds and basic functions seem fine." I don't know of any better QA tests than connecting to my rdesktop server, do you?

Note also this is:

Change looks fine, thanks for commenting/referencing the patches/sources

Reviewed_by: koobs
Approved by: koobs

Approved by: portmgr (blanket: build/run fixes, ports compliance)

Previous were just questions, thanks for commenting. Review previously (and still) accepted

Looks good!

In D17459#388854, @loader wrote:

In D17459#388221, @koobs wrote:

Please also include the updates to any ports that use these OPTIONS in their Makefile's already (thereby leveraging the new shared descriptions)

Do I also need to add RSYNC_DESC, DARCS_DESC and BAZAAR_DESC into bsd.options.desc.mk?

https://svnweb.freebsd.org/ports/head/devel/ocaml-opam/Makefile?revision=483093&view=markup#l30

30      RSYNC_DESC=             Remote repository synchronized with Rsync
31      GIT_DESC=               Remote repository synchronized with git
32      HG_DESC=                Remote repository synchronized with mercurial
33      DARCS_DESC=             Remote repository synchronized with darcs

https://svnweb.freebsd.org/ports/head/devel/cvs2svn/Makefile?revision=479407&view=markup#l30

30      SUBVERSION_DESC=        Build with subversion support
31      GIT_DESC=               Build with git support
32      BAZAAR_DESC=            Build with Bazaar support

If we are going to change all these descriptions, I should open a Bugzilla report to get an approval from the maintainer for the ports like devel/ocaml-opam, right?

Changes to Mk/bsd.options.desc.mk don't explicitly require (block on) portmgr approval

Please also include the updates to any ports that use these OPTIONS in their Makefile's already (thereby leveraging the new shared descriptions)

Ping @grembo @rodrigc would appreciate you both going over this even at first order, as you took care of the previous big 0.8->0.9 rename/update changes

In D17821#381041, @0mp wrote:

Is there a reason why USE_PYTHON=concurrent is not added to every port?

py-buildbot{-worker} Update RUN_DEPENDS, Add patch comment

devel/py-buildbot{-*}: Add extra TEST_DEPENDS, Fix test targets