Page MenuHomeFreeBSD

[NEW PORT] security/py-python-pam: Python PAM module
ClosedPublic

Authored by ml_vishwin.info on Jan 26 2019, 7:18 AM.

Details

Summary
[NEW PORT] security/py-python-pam: Python PAM module

Python PAM module

WWW: https://github.com/FirefighterBlu3/python-pam

PR: 235212
Submitted by: Charlie Li <ml+freebsd vishwin info>
Reviewed_by: koobs
Approved by: koobs
Differential_Revision: D18979
Test Plan
  • portlint: OK
  • testport: OK
  • ran python3.7 -m pam using own credentials successfully

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ml_vishwin.info set the repository for this revision to rP FreeBSD ports repository.Jan 26 2019, 7:18 AM
koobs retitled this revision from New port: security/py-python-pam to [NEW PORT] security/py-python-pam: Python PAM module.Jan 26 2019, 9:32 AM
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)
koobs added a subscriber: koobs.

Please confirm this also passes portlint

security/py-python-pam/pkg-descr
2 ↗(On Diff #53240)

Insufficient for pkg-descr contents, and its really unfortunate upstream doesn't provide anything except CLI examples in their README. I don't know what to suggest, but if we can't find something upstream or make something up, we'll have to accept it as is.

3 ↗(On Diff #53240)

Match metadata from setup.py where possible, as it is canonical. In this case setup.py:url is https://github.com/FirefighterBlu3/python-pam

portlint was run as part of testport; both pass.

ml_vishwin.info edited the test plan for this revision. (Show Details)Jan 26 2019, 11:29 AM
ml_vishwin.info marked an inline comment as done.Jan 26 2019, 11:32 AM
ml_vishwin.info added inline comments.
security/py-python-pam/pkg-descr
2 ↗(On Diff #53240)

I wish there was something better to come up with, but the actual code is such a thin wrapper around the native PAM library that any more description would be redundant at best. Even upstream's "supporting py3 (and py2)" doesn't serve much of a purpose.

ml_vishwin.info set the repository for this revision to rP FreeBSD ports repository.Jan 26 2019, 11:33 AM
koobs requested changes to this revision.Jan 26 2019, 11:37 AM
koobs added inline comments.
security/py-python-pam/Makefile
5 ↗(On Diff #53244)

Add python to CATEGORIES as a secondary/virtual category

This revision now requires changes to proceed.Jan 26 2019, 11:37 AM

Gah, how did I forget this bit?

ml_vishwin.info set the repository for this revision to rP FreeBSD ports repository.Jan 26 2019, 11:43 AM
ml_vishwin.info marked an inline comment as done.
koobs accepted this revision.Jan 26 2019, 11:53 AM
This revision is now accepted and ready to land.Jan 26 2019, 11:53 AM
koobs edited the summary of this revision. (Show Details)Jan 26 2019, 11:54 AM
koobs edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.