Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial used by TCP.
Details
Details
- Reviewers
koobs lstewart rrs 0mp - Group Reviewers
manpages transport - Commits
- rS347110: MFC r345458:
rS345458: Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thank you for this @tuexen!
sys/netinet/tcp_timer.c | ||
---|---|---|
116 ↗ | (On Diff #54376) | I don't know if we have consistent standards/guidelines for sysctl descriptions (would be nice) for 'units' 'minimum' and 'maximum' values, but, possible improvements:
So, something like: "Initial Retransmission Timeout in seconds. Minimum: 1" |
Comment Actions
The unit would be milli seconds, not seconds for the sysctl-variable. In general, I agree that it would be good to give at least the unit for sysctl variables, but
sys/netinet/tcp_timer.c | ||
---|---|---|
116 ↗ | (On Diff #54376) | All timer related sysctl variables for TCP are in ms. The documentation string I added is based on consistency with the existing ones. I agree, that giving the unit (ms) might help some users, but I think this should be added as a separate commit. I'm happy to do that once this change is in tree. |