Page MenuHomeFreeBSD

Make RTO.Initial for TCP controllable via sysctl
ClosedPublic

Authored by tuexen on Feb 25 2019, 9:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 2:16 AM
Unknown Object (File)
Dec 10 2023, 6:10 PM
Unknown Object (File)
Nov 11 2023, 3:08 PM
Unknown Object (File)
Nov 10 2023, 8:31 PM
Unknown Object (File)
Nov 10 2023, 10:15 AM
Unknown Object (File)
Oct 10 2023, 6:01 PM
Unknown Object (File)
Oct 10 2023, 2:06 PM
Unknown Object (File)
Oct 9 2023, 7:28 PM
Subscribers

Details

Summary

Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial used by TCP.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 22730

Event Timeline

Thank you for this @tuexen!

sys/netinet/tcp_timer.c
116

I don't know if we have consistent standards/guidelines for sysctl descriptions (would be nice) for 'units' 'minimum' and 'maximum' values, but, possible improvements:

  • + in seconds or Units: seconds.
  • + Minimum: 1 (based on forced min value in code above)

So, something like:

"Initial Retransmission Timeout in seconds. Minimum: 1"

The unit would be milli seconds, not seconds for the sysctl-variable. In general, I agree that it would be good to give at least the unit for sysctl variables, but

sys/netinet/tcp_timer.c
116

All timer related sysctl variables for TCP are in ms. The documentation string I added is based on consistency with the existing ones.

I agree, that giving the unit (ms) might help some users, but I think this should be added as a separate commit. I'm happy to do that once this change is in tree.

0mp added a subscriber: 0mp.

OK from manpages

This revision is now accepted and ready to land.Mar 18 2019, 1:01 PM
This revision was automatically updated to reflect the committed changes.