Page MenuHomeFreeBSD

archivers/upx: Fix build due to missing perl (pod2*) tools
ClosedPublic

Authored by koobs on Dec 14 2018, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 11, 12:47 PM
Unknown Object (File)
Jan 10 2024, 5:40 PM
Unknown Object (File)
Dec 22 2023, 12:19 AM
Unknown Object (File)
Sep 26 2023, 6:52 PM
Unknown Object (File)
Sep 25 2023, 6:52 AM
Unknown Object (File)
Aug 31 2023, 11:54 AM
Unknown Object (File)
Jul 9 2023, 7:18 PM
Unknown Object (File)
Jun 26 2023, 11:07 PM
Subscribers

Details

Summary
archivers/upx: Fix build due to missing perl (pod2*) tools

upx unconditionally runs its docs target, which relies on multiple [1] pod2*
tools provided by perl.

USES=perl and USE_PERL=build were removed in ports r478489, resulting in those
tools not being available at build time, and the following errors:

  /bin/sh: pod2man: not found
  /bin/sh: pod2html: not found
  /bin/sh: pod2text: not found

This change, accordingly, re-adds perl as an unconditional build dependency,
including a comment about what its for.

While I'm here:

  * Make COMMENT portlint compliant [2]
  
[1] pod2man, pod2html, pod2text
[2] Wikipedia, MajorGeeks and others aslso describe UPX without a "The" prefix

PR: 234002
Reported by: <mail ozzmosis com>
Approved by: portmgr (blanket: build fix, JFI)
Differential_Revision: D18549
MFH: 2018Q4
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: with/without DOCS)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

koobs edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2018, 8:44 AM
This revision was automatically updated to reflect the committed changes.