Page MenuHomeFreeBSD

sysutils/ori: Update to 0.8.2
AbandonedPublic

Authored by ali_mashtizadeh.com on Jan 28 2019, 1:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 7:17 AM
Unknown Object (File)
Dec 4 2024, 6:38 PM
Unknown Object (File)
Dec 4 2024, 6:36 PM
Unknown Object (File)
Nov 21 2024, 6:40 AM
Unknown Object (File)
Oct 27 2024, 2:51 PM
Unknown Object (File)
Oct 2 2024, 6:05 PM
Unknown Object (File)
Sep 29 2024, 8:51 AM
Unknown Object (File)
Sep 27 2024, 2:43 AM
Subscribers
None

Details

Reviewers
koobs
tobik
Summary
sysutils/ori: Update to 0.8.2

This updates fixes numerous bugs and usability improvements,
including compatibility with OpenSSL 1.0+.

PR: 232218
Differential_Revision: D18997
MFH: 2019Q1
Test Plan
  • portlint: ??
  • testport: ?? (poudriere: <versions>, <archs>, <OPTIONS> tested)
  • maketest: ?? (if test suite exists)

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22203
Build 21413: arc lint + arc unit

Event Timeline

koobs retitled this revision from Bug 232218: Update Ori release to fix build issue to sysutils/ori: Update to 0.8.2.Jan 28 2019, 2:07 AM
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)
koobs edited the summary of this revision. (Show Details)
koobs requested changes to this revision.Jan 28 2019, 2:10 AM

Syntax changes look ok, please confirm that this change passes QA (I've added items to the TEST PLAN section of this review)

sysutils/ori/Makefile
7

Is this available over https? If so, prefer https over http

sysutils/ori/distinfo
3–4

PATCHFILES removed, distinfo entries can be removed

This revision now requires changes to proceed.Jan 28 2019, 2:10 AM
tobik requested changes to this revision.Jan 28 2019, 6:13 AM

I'm afraid it doesn't build on 12.0/i386 with OpenSSL 1.1.1

build/liboriutil/key.cc:134:28: error: allocation of incomplete type 'EVP_MD_CTX' (aka 'evp_md_ctx_st')
    EVP_MD_CTX * ctx = new EVP_MD_CTX(); // XXX: openssl 1.1+ EVP_MD_CTX_new();
                           ^~~~~~~~~~
/usr/include/openssl/ossl_typ.h:92:16: note: forward declaration of 'evp_md_ctx_st'
typedef struct evp_md_ctx_st EVP_MD_CTX;
               ^
build/liboriutil/key.cc:194:28: error: allocation of incomplete type 'EVP_MD_CTX' (aka 'evp_md_ctx_st')
    EVP_MD_CTX * ctx = new EVP_MD_CTX(); // XXX: openssl 1.1+ EVP_MD_CTX_new();
                           ^~~~~~~~~~
/usr/include/openssl/ossl_typ.h:92:16: note: forward declaration of 'evp_md_ctx_st'
typedef struct evp_md_ctx_st EVP_MD_CTX;
               ^
2 errors generated.
sysutils/ori/Makefile
7

I get an Authentication Error for https.

11

It would be good to define LICENSE and LICENSE_FILE too while here.

sysutils/ori/distinfo
3–4

This is missing TIMESTAMP too. Always generate distinfo with make makesum. Do not do it by hand.

This revision now requires review to proceed.May 7 2019, 5:06 AM