Page MenuHomeFreeBSD

security/py-netmiko: Update to 2.3.0
ClosedPublic

Authored by kai on Feb 26 2019, 12:04 AM.

Details

Summary
  • Pacify portlint [1]
  • Switch to GitHub to enable test target [2]

Notable changes since 2.1.1:

  • Add support for new platforms:
    • Apresia Systems AEOS
    • Citrix Netscaler
    • Dell EMC Isilon, Dell OS10 and DNOS6
    • IP Infusion OcNOS
    • RAD ETX
  • Add fast_cli mode to improve performance
  • Add support for a session_log
  • Add Paramiko pkey, auth_timeout and passphrase support

Changelog:

https://github.com/ktbyers/netmiko/releases/tag/v2.3.0

PR: 236036
Submitted by: John W. O'Brien <john@saltant.com> [1]
Suggested by: koobs [2]
Approved by: (still open)

Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r344112 amd64 + i386) for each py27 + py36 flavor -> OK
  • portlint -> OK
  • Runtime tests -> OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kai created this revision.Feb 26 2019, 12:04 AM
koobs added a subscriber: koobs.Feb 26 2019, 3:12 AM

Suggestion:

Format the review SUMMARY field like a well-formatted commit log message. Primarily that is:

  • include the 'why' or 'rationale' for the port changes if not entirely self-explanatory by the diff.
  • include all relevant Properties: like Reviewed by: PR:, etc at the bottom
  • Separate upstream changes/changelog from the 'ports' changes like:
Changelog:

 https://github.com/ktbyers/netmiko/releases/tag/v2.3.0

Also, the package has a test suite, which is the best thing for QA. However, the tests directory doesnt seem to be packaged in the sdist.

One could USE_GITHUB until the tests are packaged (adding tests/* to MANIFEST.in). The tests use pytest (py.test -v -s tests/test_import_netmiko.py) so do-test: cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -s tests/test_import_netmiko.py should work

kai updated this revision to Diff 54408.Feb 26 2019, 10:05 AM

Addressing the suggestions by koobs:

  • Switch to GH to get the tests/ directory of the tarball
  • Add test target to easen future QA processes
kai edited the summary of this revision. (Show Details)Feb 26 2019, 10:14 AM
kai added a comment.Feb 26 2019, 10:31 AM

Suggestion:
Format the review SUMMARY field like a well-formatted commit log message. Primarily that is:

  • include the 'why' or 'rationale' for the port changes if not entirely self-explanatory by the diff.
  • include all relevant Properties: like Reviewed by: PR:, etc at the bottom

Thank you for your feedback. I updated the summary a bit to reflect your suggestions.

  • Separate upstream changes/changelog from the 'ports' changes like:

One question here: Does it make sense to highlight some of upstream's major changes in the commit log? Or should it be just reduced/omitted to:

Changelog:
 https://github.com/ktbyers/netmiko/releases/tag/v2.3.0

Also, the package has a test suite, which is the best thing for QA. However, the tests directory doesnt seem to be packaged in the sdist.
One could USE_GITHUB until the tests are packaged (adding tests/* to MANIFEST.in). The tests use pytest (py.test -v -s tests/test_import_netmiko.py) so do-test: cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -s tests/test_import_netmiko.py should work

I switched from CHEESESHOP to GH and implemented the test target. The tests were successful with py27 and py36.

miwi accepted this revision.Feb 28 2019, 11:36 AM

LGTM

This revision is now accepted and ready to land.Feb 28 2019, 11:36 AM
This revision was automatically updated to reflect the committed changes.