Mark, do you suppose that this can fix some another strange panics that appeared after epochification?

LGTM.

Note, that automatic loading for cxgbe can do unexpected firmware update when user does first boot.

LGTM.

I think you may find useful ipfw_pmod module too, it adds support for TCP MSS modification, but, yes, it is not related to IPv6. However, ng_tcpmss does not support TCP over IPv6, but ipfw_pmod does :)

In D19622#421205, @bz wrote:

@glebius and @hselasky rather than changing pr_drain I wondered about an eventhandler or something as that way dealing with non-protocol places such as firewalls, netisr, .. would also be possible? I think not queuing is not an option, arp queue is just another one of these places... there's more and more the longer I think about it... We'll need something to get them all (and getting the locking right).

Committed in rS345262, rS345263, rS345264, rS345274.

Remove object files. Sorry.

Fix misused ENOENT in some places.

Add missing TOK_STATES_CHUNKS token

I have no objection. AFAIR, the main goal of this change was the adding ability to extend number of entries for some tables, that have very little number of partition entries, e.g. 1 or 2.
I think if you revert this change, then you will not able to add new partitions for these tables, even if there are enough space to keep them.

Looks reasonable.

In D18904#405557, @karels wrote:

arprequest_internal would be better.

Can you explain your goal? Not sure what you are trying to solve with this rlock. Please, note that LAGG_RLOCK() is epoch_enter() and it seem used to make safe lagg_port reclamation using epoch_call().

Ah, yes, I remembered, this problem was introduced with route caching.

In D18769#400967, @hselasky wrote:

So, why you think that this is wrong and shouldn't happen?

Because then TCP loopback on non-lo0 link-local addresses won't work.

The current code would drop packets which are designated for loopback which use a link-local scope ID in the destination address or source address, because they won't match the lo0's scope ID.

• reordered some fields and reduced the size of hopstore6, now ip_fw_args fits into 128 bytes.
• the fwd code adjusted to use new hopstore6.

In D18690#398876, @gallatin wrote:

I really like collapsing all those pointers, and making the NULL checks flags. Great work.

I wonder if more collapsing could be done. For example, it seems like src_ip and dst_ip could share unions with src_ip6 and dst_ip6 in struct ipfw_flow_id(). That would take us down to 136 bytes. Only 8 more bytes and it would fit in 2 64 byte cachelines.

How would you merge it without breaking the ifnet KBI? We've got 3rd party network interfaces in ports, etc...

I think such method can be useful. Do you plan to merge it?