Page MenuHomeFreeBSD

cxgbe(4): Integrate with PNP PCIID-based autoload
AbandonedPublic

Authored by cem on Mar 29 2019, 7:00 PM.

Details

Reviewers
np
jhb
imp
Summary

PR: 236886

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23386
Build 22404: arc lint + arc unit

Event Timeline

cem created this revision.Mar 29 2019, 7:00 PM
imp added a comment.Mar 30 2019, 6:28 AM

jhb specifically asked me not to do this driver. Please be sure to get sign off from him.

ae added a comment.Mar 30 2019, 10:11 AM

Note, that automatic loading for cxgbe can do unexpected firmware update when user does first boot.

jhb added a comment.Apr 1 2019, 5:42 PM

It's really @np who should sign off on this. I can blacklist the driver on my dev boxes since since there's now an rc.conf variable to exempt drivers from devmatch which would be sufficient for my needs.

cem added a comment.EditedApr 1 2019, 7:58 PM
In D19754#424087, @jhb wrote:

It's really @np who should sign off on this. I can blacklist the driver on my dev boxes since since there's now an rc.conf variable to exempt drivers from devmatch which would be sufficient for my needs.

Yep, I agree, and that's what I've been holding off for.

If people perceive the auto-upgrading of firmware as deleterious, maybe that's an indication of a feature that should be disabled? It could always be made a tunable to give users the option to opt in? It's not my driver -- I think np@ gets to make that call.

ae added a comment.Apr 22 2019, 11:10 AM

We have single machine, that after automatic firmware upgrade fails to attache the driver:

t5nex0: <Chelsio T580-LP-SO-CR> mem 0xfb300000-0xfb37ffff,0xfa000000-0xfaffffff,0xfb984000-0xfb985fff irq 64 at device 0.4 numa-domain 1 on pci9
t5nex0: firmware on card (1.16.63.0) is older than the version bundled with this driver, installing firmware 1.19.1.0 on card.
t5nex0: fw init failed: 5.
t5nex0: error during attach, adapter is now in recovery mode.
device_attach: est5 attach returned 6
t5nex0: <Chelsio T580-LP-SO-CR> mem 0xfb300000-0xfb37ffff,0xfa000000-0xfaffffff,0xfb984000-0xfb985fff irq 64 at device 0.4 numa-domain 1 on pci9
t5nex0: firmware on card (1.19.1.0) is older than the version bundled with this driver, installing firmware 1.23.0.0 on card.
t5nex0: fw init failed: 5.
t5nex0: error during attach, adapter is now in recovery mode.
t5nex0: <Chelsio T580-LP-SO-CR> mem 0xfb300000-0xfb37ffff,0xfa000000-0xfaffffff,0xfb984000-0xfb985fff irq 64 at device 0.4 numa-domain 1 on pci9
t5nex0: failed to connect to the firmware: 16, 963208048.
t5nex0: error during attach, adapter is now in recovery mode.

So, it can be dangerous...

cem added a comment.Apr 22 2019, 3:50 PM
In D19754#429906, @ae wrote:

We have single machine, that after automatic firmware upgrade fails to attache the driver:
...
So, it can be dangerous...

Ok, that seems like maybe a misfeature in cxgbe :-(. I won't commit this with that unresolved (or without np@'s approval).

cem abandoned this revision.Aug 17 2019, 6:52 PM