In D44011#1007029, @arrowd wrote:

Sorry for being late to the party, but what's the point in

1. Rewriting it, since we have sysutils/pam_xdg?
2. Having it in base instead of port?

In D44011#1006994, @jbeich wrote:

Is the module name clash with sysutils/pam_xdg intentional? It creates a POLA violation on upgrade: /var/run/user/<uid> moves to /var/run/xdg/<uname>.

check other fstatat

check fstatat return value

style(9)

also check directory ownership and mode at close

Check already existing directory for ownership and mode.

In D44011#1004814, @des wrote:

I'm not sure the logic in _pam_xdg_close() is correct. You seem to always close the last session, right? So if I initiate session A and then initiate session B and then log out of session A it will remove the user directory that was created for, and is potentially being used by, session B, which is still active, while leaving the user directory that was used by session A and is now unused in place.

Address des@ comments.

setup -> sets up

Address latest des@ comments.

Add a few comments and close a few fd

Add it to xdm too

Address some of des@ comments.

Is phab drunk ?
stand/libsa/md.c : This file was moved from stand/common/md.c.
stand/common/md.c : This file was moved to stand/libsa/md.c.

In D43849#1000334, @jrtc27 wrote:

Doing this for the Unmatched doesn’t seem very useful when we can’t use the SD card for our rootfs due to driver limitations.

In D43846#1000175, @imp wrote:

This change is correct. It should be made no matter what. Puc is tied to pci.

I've tried to make a puc_bus module that contain dev/uart/uart_bus_puc.c and make puc depends on this, but behavior is the same.

Would be better to do only one commit yes.

You need to set U_BOOT_SLAVE_PORTREVISION_2024.01= 1 in the Makefile too.

Just basic style(9) review.
Also you should add the devices in sys/arm64/conf/std.nxp

We have a new-ish directory sys/dev/iicbus/controller/ for i2c controllers, it should go there.