Differential D44012

pam: Always use pam_xdg for session and xdm
ClosedPublic
Actions

Authored by manu on Feb 21 2024, 2:58 PM.

Details

Reviewers

des

Group Reviewers

x11

Commits

rG8bca4da5bca3: pam: Always use pam_xdg for session and xdm
rG6b9e6f12e5bb: pam: Always use pam_xdg for session and xdm

Summary

This ensure that the XDG_RUNTIME_DIR is always created and the environment
variable is present which is a must for any wayland user (at least).
The only "cost" of it is a directory is created and unused.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Test Plan

Tested with x11/ly (wayland and x11), x11/sddm (wayland and x11), x11/xdm and login on the console.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

manu created this revision.Feb 21 2024, 2:58 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2024, 2:58 PM

manu requested review of this revision.Feb 21 2024, 2:58 PM

Harbormaster completed remote builds in B56151: Diff 134797.Feb 21 2024, 2:58 PM

manu added a parent revision: D44011: pam: Add pam_xdg module.Feb 21 2024, 2:59 PM

manu added reviewers: x11, des.

Add it to xdm too

Harbormaster completed remote builds in B56167: Diff 134826.Feb 22 2024, 6:07 AM

manu retitled this revision from pam: Always use pam_xdg for session to pam: Always use pam_xdg for session and xdm.Feb 22 2024, 6:07 AM

manu edited the test plan for this revision. (Show Details)Feb 22 2024, 8:33 AM

des accepted this revision.Feb 22 2024, 6:15 PM

This revision is now accepted and ready to land.Feb 22 2024, 6:15 PM

Closed by commit rG6b9e6f12e5bb: pam: Always use pam_xdg for session and xdm (authored by manu). · Explain WhyFeb 26 2024, 5:36 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG6b9e6f12e5bb: pam: Always use pam_xdg for session and xdm.

manu added a commit: rG8bca4da5bca3: pam: Always use pam_xdg for session and xdm.Apr 11 2024, 1:25 PM

Was that change adequately tested?

It did it break LightDM with a ghome-keyring.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279669.

That also breaks the GhostBSD gnome-keyring setup.

Revision Contents
Changeset List

Path

Size

lib/

libpam/

pam.d/

system

1 line

xdm

1 line

Diff 135017

View Options

lib/libpam/pam.d/system