Page MenuHomeFreeBSD
Feed Advanced Search

Jun 24 2016

honzhan_microsoft.com added a reviewer for D6955: hyperv/stor: Fix the issue of uncorrect disk filtering: mva.
Jun 24 2016, 10:35 AM
honzhan_microsoft.com updated the diff for D6955: hyperv/stor: Fix the issue of uncorrect disk filtering.
Jun 24 2016, 10:34 AM
honzhan_microsoft.com added reviewers for D6955: hyperv/stor: Fix the issue of uncorrect disk filtering: sepherosa_gmail.com, royger, decui_microsoft.com, howard0su_gmail.com.
Jun 24 2016, 7:16 AM
honzhan_microsoft.com retitled D6955: hyperv/stor: Fix the issue of uncorrect disk filtering from to hyperv/stor: Fix the issue of uncorrect disk filtering.
Jun 24 2016, 6:54 AM

May 11 2016

honzhan_microsoft.com updated the diff for D6316: hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016.
May 11 2016, 8:30 AM
honzhan_microsoft.com updated the diff for D6316: hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016.
May 11 2016, 6:44 AM
honzhan_microsoft.com added inline comments to D6316: hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016.
May 11 2016, 5:57 AM
honzhan_microsoft.com retitled D6316: hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016 from hyperv/stor: Disable invalid disk filtering on non-win10/win2k16 to hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016.
May 11 2016, 5:41 AM
honzhan_microsoft.com retitled D6316: hyperv/stor: Disable invalid disk filtering on non-win10 or non-win 2016 from to hyperv/stor: Disable invalid disk filtering on non-win10/win2k16.
May 11 2016, 5:37 AM

Mar 13 2016

honzhan_microsoft.com added inline comments to D5619: Remove unnecessary sema, use msleep instead.
Mar 13 2016, 4:30 AM

Mar 1 2016

honzhan_microsoft.com added reviewers for D5508: hyperv: netvsc: VRSS step1: multiple channel support: decui_microsoft.com, howard0su_gmail.com, sepherosa_gmail.com.

This is the first step for VRSS: multiple channel support. It passes build & simple test, and need more test.

Mar 1 2016, 3:06 PM
honzhan_microsoft.com retitled D5508: hyperv: netvsc: VRSS step1: multiple channel support from to hyperv: netvsc: VRSS step1: multiple channel support.
Mar 1 2016, 3:02 PM

Feb 26 2016

honzhan_microsoft.com accepted D5452: hyperv/hn: Pass channel as the channel callback argument.
Feb 26 2016, 5:35 AM
honzhan_microsoft.com accepted D5450: hyperv: Remove useless channel inbound_lock.
Feb 26 2016, 2:56 AM
honzhan_microsoft.com updated the test plan for D5343: WIP: hyperv/kvp Cleanup KVP logic.
Feb 26 2016, 2:03 AM

Feb 25 2016

honzhan_microsoft.com accepted D5439: hyperv: Use atomic_fetchadd_int to get GPADL id..
Feb 25 2016, 9:04 AM
honzhan_microsoft.com added a comment to D5439: hyperv: Use atomic_fetchadd_int to get GPADL id..

Yes, substract the next_gpadl_handle is risk here.

Feb 25 2016, 9:03 AM
honzhan_microsoft.com updated the diff for D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 25 2016, 6:23 AM
honzhan_microsoft.com added inline comments to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 25 2016, 6:21 AM
honzhan_microsoft.com added inline comments to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 25 2016, 6:07 AM
honzhan_microsoft.com updated the diff for D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 25 2016, 6:03 AM
honzhan_microsoft.com added a comment to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.

The update includes:

  1. Reuse "dev.DEV.UNIT." as sysctl root node instead of defining a new node.
  2. Separate the statisitc into two parts: hv_vmbus_channel_stat and hv_ring_buffer_stat. The former is owned by channel module, and the later is for ring_buffer module. Because the statistic needs to know which ring buffer it is: inbound or outbound, that is only known in channel level. It is not suitable to bind all logic to hv_vmbus_ring_buffer_init function even though I tried it but found the logic is not clean.
  3. Add the support for sub channel. There is a node "sub" in the output.
Feb 25 2016, 5:58 AM
honzhan_microsoft.com updated the diff for D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 25 2016, 5:33 AM

Feb 24 2016

honzhan_microsoft.com added a comment to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.

My intension of creating more nodes is for printing clear message. We have to distinguish ring buffers on different channels, so they belong to the same node. Maybe we also needs to distinguish subchannels. Now I have not done this.

Feb 24 2016, 2:06 AM

Feb 23 2016

honzhan_microsoft.com updated the diff for D5402: hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 23 2016, 10:50 AM
honzhan_microsoft.com added a comment to D5402: hyperv: vmbus: add statistic (stats) for ring buffer.

hmm, it makes sense to put ring_buffer_stats function into hv_ring_buffer.c since only one function exists in that file.

Feb 23 2016, 8:35 AM
honzhan_microsoft.com added reviewers for D5402: hyperv: vmbus: add statistic (stats) for ring buffer: delphij, adrian.
Feb 23 2016, 8:13 AM
honzhan_microsoft.com added reviewers for D5402: hyperv: vmbus: add statistic (stats) for ring buffer: decui_microsoft.com, howard0su_gmail.com, royger, sepherosa_gmail.com.
Feb 23 2016, 8:13 AM
honzhan_microsoft.com removed reviewers for D5402: hyperv: vmbus: add statistic (stats) for ring buffer: sepherosa_gmail.com, royger, howard0su_gmail.com, delphij, decui_microsoft.com, adrian.
Feb 23 2016, 8:12 AM
honzhan_microsoft.com added reviewers for D5402: hyperv: vmbus: add statistic (stats) for ring buffer: adrian, decui_microsoft.com, delphij, howard0su_gmail.com, royger, sepherosa_gmail.com.
Feb 23 2016, 8:11 AM
honzhan_microsoft.com retitled D5402: hyperv: vmbus: add statistic (stats) for ring buffer from to hyperv: vmbus: add statistic (stats) for ring buffer.
Feb 23 2016, 8:06 AM

Feb 17 2016

honzhan_microsoft.com added a comment to D5086: hyperv: vmbus: refactor msg handler by replacing swi with task queue.

There is another succinct implementation with taskqueue_fast. Please reference https://reviews.freebsd.org/D5215

Feb 17 2016, 2:58 PM

Feb 16 2016

honzhan_microsoft.com added inline comments to D4803: hyperv: vmbus: ring buffer optimization on host pending content to write.
Feb 16 2016, 10:39 AM
honzhan_microsoft.com added a comment to D5216: vmm/hyperv: code cleanup of utility drivers.

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

Feb 16 2016, 6:17 AM
honzhan_microsoft.com accepted D5274: hyperv/hn: Change global tunable prefix to hw.hn.

LGTM

Feb 16 2016, 2:27 AM

Feb 5 2016

honzhan_microsoft.com accepted D5199: hyperv/hn: Fix typo in comment.
Feb 5 2016, 6:25 AM

Feb 4 2016

honzhan_microsoft.com accepted D5175: hyperv/hn: Add an option to always do transmission scheduling.

Looks ok to me.

Feb 4 2016, 12:45 AM

Jan 31 2016

honzhan_microsoft.com added inline comments to D4803: hyperv: vmbus: ring buffer optimization on host pending content to write.
Jan 31 2016, 4:42 AM

Jan 29 2016

honzhan_microsoft.com accepted D5098: hyperv/hn: Reorganize TX csum offloading.
Jan 29 2016, 10:42 AM
honzhan_microsoft.com accepted D4963: Use standard taskqueue instead of hv_work_queue.
Jan 29 2016, 10:41 AM
honzhan_microsoft.com accepted D5103: hyperv/hn: Add sysctl to trust host side UDP and IP csum verification.
Jan 29 2016, 10:06 AM

Jan 28 2016

honzhan_microsoft.com added inline comments to D5103: hyperv/hn: Add sysctl to trust host side UDP and IP csum verification.
Jan 28 2016, 10:07 AM
honzhan_microsoft.com accepted D5085: hyperv/hn: Avoid duplicate csum features settings.

LGTM

Jan 28 2016, 7:58 AM
honzhan_microsoft.com added inline comments to D5097: hyperv: stor: Fix the NULL pointer dereference.
Jan 28 2016, 5:25 AM
honzhan_microsoft.com added reviewers for D5097: hyperv: stor: Fix the NULL pointer dereference: adrian, decui_microsoft.com, delphij, howard0su_gmail.com, royger, sepherosa_gmail.com.
Jan 28 2016, 1:53 AM
honzhan_microsoft.com retitled D5097: hyperv: stor: Fix the NULL pointer dereference from to hyperv: stor: Fix the NULL pointer dereference.
Jan 28 2016, 1:49 AM

Jan 27 2016

honzhan_microsoft.com added reviewers for D5086: hyperv: vmbus: refactor msg handler by replacing swi with task queue: adrian, decui_microsoft.com, delphij, howard0su_gmail.com, royger, sepherosa_gmail.com.
Jan 27 2016, 7:55 AM
honzhan_microsoft.com retitled D5086: hyperv: vmbus: refactor msg handler by replacing swi with task queue from to hyperv: vmbus: refactor msg handler by replacing swi with task queue.
Jan 27 2016, 7:50 AM
honzhan_microsoft.com abandoned D4800: Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU..
Jan 27 2016, 5:17 AM
honzhan_microsoft.com updated the diff for D4800: Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU..
  • hyperv: vmbus: refactor msg handler by replacing swi with task queue
Jan 27 2016, 5:13 AM
honzhan_microsoft.com added inline comments to D4963: Use standard taskqueue instead of hv_work_queue.
Jan 27 2016, 4:37 AM

Jan 21 2016

honzhan_microsoft.com updated the diff for D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 21 2016, 2:54 PM

Jan 20 2016

honzhan_microsoft.com updated the diff for D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 20 2016, 6:01 AM
honzhan_microsoft.com accepted D4991: hyperv/hn: Trust host TCP segment checksum verification by default.

It looks ok to me.

Jan 20 2016, 3:05 AM
honzhan_microsoft.com added inline comments to D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 20 2016, 1:49 AM

Jan 19 2016

honzhan_microsoft.com updated the diff for D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 19 2016, 8:19 AM
honzhan_microsoft.com added inline comments to D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 19 2016, 7:07 AM

Jan 18 2016

honzhan_microsoft.com added inline comments to D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 18 2016, 10:42 AM
honzhan_microsoft.com added inline comments to D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 18 2016, 9:38 AM
honzhan_microsoft.com added inline comments to D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 18 2016, 9:37 AM
honzhan_microsoft.com updated the diff for D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 18 2016, 8:16 AM
honzhan_microsoft.com updated the diff for D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 18 2016, 7:59 AM
honzhan_microsoft.com updated the diff for D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 18 2016, 7:05 AM
honzhan_microsoft.com updated the diff for D4802: hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 18 2016, 4:42 AM

Jan 14 2016

honzhan_microsoft.com added reviewers for D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016: whu, royger, decui_microsoft.com, howard0su_gmail.com, delphij, sepherosa_gmail.com, kmacy.
Jan 14 2016, 1:12 AM
honzhan_microsoft.com retitled D4928: hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016 from to hyperv: storvsc: Fix multiple invalid disk issue for FreeBSD on windows 10/2016.
Jan 14 2016, 1:02 AM

Jan 12 2016

honzhan_microsoft.com updated the diff for D4803: hyperv: vmbus: ring buffer optimization on host pending content to write.

replace "false" with "FALSE" in order to be consistent with other "FALSE" in the same file.

Jan 12 2016, 9:54 AM
honzhan_microsoft.com added a comment to D4803: hyperv: vmbus: ring buffer optimization on host pending content to write.

According to howard0su_gmail.com's suggestion, I did corresponding modifications except for "boolean_t==>bool" in order to keep consistent in current file. In the future, I will do a special code refactor in order to align with FreeBSD's mainstream style.

Jan 12 2016, 2:46 AM
honzhan_microsoft.com updated the diff for D4803: hyperv: vmbus: ring buffer optimization on host pending content to write.
Jan 12 2016, 2:40 AM

Jan 11 2016

honzhan_microsoft.com added a comment to D4594: hyperv: netvsc: remove the dummy netvsc_init().

Looks ok to me.

Jan 11 2016, 3:06 AM

Jan 8 2016

honzhan_microsoft.com added a comment to D4824: hyperv/hn: Implement LRO.
  1. When the statistic data was reset or cleared? I found if I enable LRO and run some test, and then disable LRO, the statistic data are still there.
  2. Please follow the style (9) for all "return" statement. e.g. "return IPPROTO_DONE;" should be changed to "return (IPPROTO_DONE);"
  3. For TUNABLE_INT("dev.hn.trust_hosttcp", &hn_trust_hosttcp); "dev.hn.trust_hosttcp" is not a generic option for network, instead it only makes sense for hyperv network driver, so could you please rename it to be "dev.hyperv.trust_hosttcp"? "hn" makes people think it is "hn0".
Jan 8 2016, 3:13 AM

Jan 7 2016

honzhan_microsoft.com retitled D4814: Hyperv: netvsc: Set net_dev's recv buffer size according to NVSP protocol version from to Hyperv: netvsc: Set net_dev's recv buffer size according to NVSP protocol version.
Jan 7 2016, 10:56 AM

Jan 6 2016

honzhan_microsoft.com retitled D4803: hyperv: vmbus: ring buffer optimization on host pending content to write from to hyperv: vmbus: ring buffer optimization on host pending content to write.
Jan 6 2016, 9:42 AM
honzhan_microsoft.com retitled D4802: hyperv: vmbus: Optimize channel lookup through id through a map table from to hyperv: vmbus: Optimize channel lookup through id through a map table.
Jan 6 2016, 5:02 AM
honzhan_microsoft.com added a reviewer for D4800: Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU.: sepherosa_gmail.com.
Jan 6 2016, 3:15 AM
honzhan_microsoft.com added reviewers for D4800: Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU.: whu, royger, delphij, kmacy, howard0su_gmail.com, decui_microsoft.com.
Jan 6 2016, 2:49 AM
honzhan_microsoft.com retitled D4800: Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU. from to Hyperv: vmbus: Use INTR_MPSAFE in swi_add and bind swi thread to each CPU..
Jan 6 2016, 2:42 AM

Nov 16 2015

honzhan_microsoft.com updated the diff for D4131: Fix a checksum offloading bug in Hyper-V netvsc driver.

refine the patch according to Wei Hu's comments

Nov 16 2015, 2:55 AM

Nov 12 2015

honzhan_microsoft.com added a reviewer for D4131: Fix a checksum offloading bug in Hyper-V netvsc driver: royger.

Could you please help me review the bug fix?

Nov 12 2015, 9:51 AM
honzhan_microsoft.com added a reviewer for D4131: Fix a checksum offloading bug in Hyper-V netvsc driver: whu.
Nov 12 2015, 9:49 AM
honzhan_microsoft.com retitled D4131: Fix a checksum offloading bug in Hyper-V netvsc driver from to Fix a checksum offloading bug in Hyper-V netvsc driver.
Nov 12 2015, 9:45 AM