Page MenuHomeFreeBSD
Differential D5097

hyperv: stor: Fix the NULL pointer dereference
ClosedPublic
Actions

Authored by honzhan_microsoft.com on Jan 28 2016, 1:49 AM.
Tags
None
Referenced Files
F115323975: D5097.id.diff
Tue, Apr 22, 2:45 PM
F115319106: D5097.id12773.diff
Tue, Apr 22, 1:29 PM
F115315396: D5097.id12773.diff
Tue, Apr 22, 12:39 PM
F115315152: D5097.id.diff
Tue, Apr 22, 12:37 PM
F115312924: D5097.diff
Tue, Apr 22, 12:14 PM
F115312133: D5097.diff
Tue, Apr 22, 12:06 PM
Unknown Object (File)
Mon, Apr 14, 6:24 AM
Unknown Object (File)
Mon, Apr 14, 3:08 AM
View All 92 Files
Subscribers
imp
mmokhi
Contributor Reviews (src)

Details

Reviewers
howard0su_gmail.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian
Commits
rS295295: hyperv/stor: Fix the NULL pointer dereference
Summary

There are potential NULL pointer dereference issues.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

honzhan_microsoft.com updated this revision to Diff 12773.Jan 28 2016, 1:49 AM
honzhan_microsoft.com retitled this revision from to hyperv: stor: Fix the NULL pointer dereference.
honzhan_microsoft.com updated this object.
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 28 2016, 1:49 AM
honzhan_microsoft.com added reviewers: adrian, decui_microsoft.com, delphij, howard0su_gmail.com, royger, sepherosa_gmail.com.Jan 28 2016, 1:53 AM
adrian accepted this revision.Jan 28 2016, 1:54 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2016, 1:54 AM
sepherosa_gmail.com added inline comments.Jan 28 2016, 1:56 AM
sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
1529 ↗(On Diff #12773)

Could we just move the LIST_REMOVE after the NULL check?

honzhan_microsoft.com added inline comments.Jan 28 2016, 5:25 AM
sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
1529 ↗(On Diff #12773)

Yes, that is ok. But I prefer to do checking with the LIST macros.

sepherosa_gmail.com accepted this revision.Jan 28 2016, 5:27 AM
sepherosa_gmail.com edited edge metadata.

Looks fine to me

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c
1529 ↗(On Diff #12773)

Well, fine, its your call.

mmokhi added a subscriber: mmokhi.Jan 28 2016, 6:01 AM
decui_microsoft.com accepted this revision.Jan 28 2016, 7:34 AM
decui_microsoft.com edited edge metadata.

LGTM

Closed by commit rS295295: hyperv/stor: Fix the NULL pointer dereference (authored by sephe). · Explain WhyFeb 5 2016, 3:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
storvsc/
13 lines

Diff 13029

View Options

head/sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

Loading...