Page MenuHomeFreeBSD
Differential D4991

hyperv/hn: Trust host TCP segment checksum verification by default
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jan 19 2016, 1:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 1:37 AM
Unknown Object (File)
Tue, Apr 30, 1:32 AM
Unknown Object (File)
Nov 27 2023, 5:34 AM
Unknown Object (File)
Nov 21 2023, 9:27 AM
Unknown Object (File)
Nov 9 2023, 3:35 AM
Unknown Object (File)
Nov 8 2023, 1:05 AM
Unknown Object (File)
Oct 28 2023, 5:17 PM
Unknown Object (File)
Oct 20 2023, 8:25 AM
View All 49 Files
Subscribers
freebsd-net-list

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian
Group Reviewers
network
Commits
rS294703: hyperv/hn: Trust host TCP segment checksum verification by default.
Summary
According to all available information, VMSWITCH always does the
TCP segment checksum verification before send the segment to guest.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 12443.Jan 19 2016, 1:26 AM
sepherosa_gmail.com retitled this revision from to hyperv/hn: Trust host TCP segment checksum verification by default.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: network, adrian, delphij, honzhan_microsoft.com, howard0su_gmail.com, royger, decui_microsoft.com.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
delphij accepted this revision.Jan 19 2016, 1:31 AM
delphij edited edge metadata.

I think the change is Okay but would suggest that this be documented as a CTLFLAG_RDTUN sysctl so it's easier for users to figure out what they means (and their present value).

This revision is now accepted and ready to land.Jan 19 2016, 1:31 AM
sepherosa_gmail.com added a comment.Jan 19 2016, 1:35 AM
In D4991#105751, @delphij wrote:

I think the change is Okay but would suggest that this be documented as a CTLFLAG_RDTUN sysctl so it's easier for users to figure out what they means (and their present value).

Heh, the sysctl for this tunable was in the devclass sysctl tree, they are just added dynamically, since the devclass sysctl tree is created dynamiclly. On this hyperv (I used to write this reply down :):

fbsd-cur-sephe:netvsc# sysctl dev.hn
dev.hn.tso_maxlen: 0
dev.hn.tx_chimney_size: 0
dev.hn.trust_hosttcp: 1

delphij added a comment.Jan 19 2016, 1:37 AM
In D4991#105759, @sepherosa_gmail.com wrote:
In D4991#105751, @delphij wrote:

I think the change is Okay but would suggest that this be documented as a CTLFLAG_RDTUN sysctl so it's easier for users to figure out what they means (and their present value).

Heh, the sysctl for this tunable was in the devclass sysctl tree, they are just added dynamically, since the devclass sysctl tree is created dynamiclly. On this hyperv (I used to write this reply down :):

fbsd-cur-sephe:netvsc# sysctl dev.hn
dev.hn.tso_maxlen: 0
dev.hn.tx_chimney_size: 0
dev.hn.trust_hosttcp: 1

I see, thanks for the explanation.

honzhan_microsoft.com accepted this revision.Jan 20 2016, 3:05 AM
honzhan_microsoft.com edited edge metadata.

It looks ok to me.

adrian accepted this revision.Jan 22 2016, 3:37 AM
adrian edited edge metadata.
Closed by commit rS294703: hyperv/hn: Trust host TCP segment checksum verification by default. (authored by sephe). · Explain WhyJan 25 2016, 5:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
netvsc/
2 lines

Diff 12672

View Options

head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Loading...