Page MenuHomeFreeBSD
Differential D4963

Use standard taskqueue instead of hv_work_queue
ClosedPublic
Actions

Authored by howard0su_gmail.com on Jan 17 2016, 12:12 PM.
Tags
None
Referenced Files
F82625460: D4963.id12536.diff
Wed, May 1, 12:07 AM
Unknown Object (File)
Mon, Apr 22, 12:54 PM
Unknown Object (File)
Mar 15 2024, 11:24 AM
Unknown Object (File)
Mar 2 2024, 5:02 AM
Unknown Object (File)
Feb 12 2024, 8:36 PM
Unknown Object (File)
Feb 12 2024, 5:37 PM
Unknown Object (File)
Jan 27 2024, 11:26 PM
Unknown Object (File)
Jan 10 2024, 7:04 AM
View All Files
Subscribers
imp

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
sepherosa_gmail.com
royger
adrian
Group Reviewers
Contributor Reviews (src)
Commits
rS295307: hyperv: Use standard taskqueue instead of hv_work_queue
Summary

HyperV code was porting from Linux. There is an implementation of work queue
called as hv_work_queue. In FreeBSD, taskqueue is using for the same
purpose. Convert all the consumer of hv_work_queue to using taskqueue and remove work
queue implementation.

The net impact is reduced code and make the driver more FreeBSD style.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 12382.Jan 17 2016, 12:12 PM
howard0su_gmail.com retitled this revision from to Use standard taskqueue instead of hv_work_queue.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJan 17 2016, 12:12 PM
Herald added a subscriber: imp. · View Herald Transcript
howard0su_gmail.com updated this revision to Diff 12383.Jan 17 2016, 12:57 PM
howard0su_gmail.com edited edge metadata.

Fix a error logic which can lead to panic

howard0su_gmail.com added reviewers: sepherosa_gmail.com, royger, decui_microsoft.com, honzhan_microsoft.com.Jan 17 2016, 12:58 PM
koobs edited reviewers, added: Contributor Reviews (src); removed: Contributor Reviewers (ports).Jan 20 2016, 6:27 AM
howard0su_gmail.com updated this revision to Diff 12536.Jan 21 2016, 6:51 AM

Cleanup header file, recycle unused defs.
also update one place which can use WAITOK now.

howard0su_gmail.com added a child revision: D5081: Remove NOWAIT in the places where actually can wait..Jan 27 2016, 2:35 AM
honzhan_microsoft.com added inline comments.Jan 27 2016, 4:37 AM
sys/dev/hyperv/vmbus/hv_connection.c
167 ↗(On Diff #12536)

This sema can be removed. It is only used in hv_work_queue_create which has been removed by this patch.

268 ↗(On Diff #12536)

remove

320 ↗(On Diff #12536)

It can be removed.

howard0su_gmail.com updated this revision to Diff 12740.Jan 27 2016, 4:57 AM

rebase to HEAD

howard0su_gmail.com updated this revision to Diff 12755.Jan 27 2016, 2:10 PM

address review comments, remove control_sema

honzhan_microsoft.com accepted this revision.Jan 29 2016, 10:41 AM
honzhan_microsoft.com edited edge metadata.
This revision is now accepted and ready to land.Jan 29 2016, 10:41 AM
howard0su_gmail.com updated this revision to Diff 12919.Feb 1 2016, 4:26 AM
howard0su_gmail.com edited edge metadata.

Remove a empty pair of lock/unlock

This revision now requires review to proceed.Feb 1 2016, 4:26 AM
howard0su_gmail.com added a reviewer: adrian.Feb 4 2016, 4:48 AM
adrian accepted this revision.Feb 4 2016, 5:48 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Feb 4 2016, 5:48 AM
Closed by commit rS295307: hyperv: Use standard taskqueue instead of hv_work_queue (authored by sephe). · Explain WhyFeb 5 2016, 7:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
include/
33 lines
utilities/
35 lines
58 lines
vmbus/
231 lines
7 lines
22 lines
6 lines

Diff 13045

View Options

head/sys/dev/hyperv/include/hyperv.h

Loading...
View Options

head/sys/dev/hyperv/utilities/hv_kvp.c

Loading...
View Options

head/sys/dev/hyperv/utilities/hv_util.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_connection.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_priv.h

Loading...