Page MenuHomeFreeBSD
Differential D5081

Remove NOWAIT in the places where actually can wait.
ClosedPublic
Actions

Authored by howard0su_gmail.com on Jan 26 2016, 12:26 PM.
Tags
None
Referenced Files
F171032933: D5081.id12742.diff
Tue, Sep 8, 7:32 AM
Unknown Object (File)
Sun, Sep 6, 1:33 PM
Unknown Object (File)
Sun, Sep 6, 1:56 AM
Unknown Object (File)
Sat, Sep 5, 1:33 PM
Unknown Object (File)
Sat, Sep 5, 12:40 PM
Unknown Object (File)
Sat, Sep 5, 9:50 AM
Unknown Object (File)
Sat, Sep 5, 6:30 AM
Unknown Object (File)
Sat, Sep 5, 3:51 AM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
delphij
sepherosa_gmail.com
royger
adrian
Commits
rS295308: hyperv: Use WAITOK in the places where we can wait
Summary

use M_WAITOK when applicatable
Remove code to check NULL return values.
Convert sc_lock to normal mutex

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

howard0su_gmail.com updated this revision to Diff 12717.Jan 26 2016, 12:26 PM
howard0su_gmail.com retitled this revision from to Remove NOWAIT in the places where actually can wait..
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJan 26 2016, 12:26 PM
howard0su_gmail.com added reviewers: decui_microsoft.com, honzhan_microsoft.com, royger, sepherosa_gmail.com, delphij.Jan 27 2016, 2:35 AM
howard0su_gmail.com added parent revisions: D4920: Hyperv: Event handling code refactor., D4963: Use standard taskqueue instead of hv_work_queue.
howard0su_gmail.com updated this revision to Diff 12742.Jan 27 2016, 5:46 AM

rebase to HEAD

howard0su_gmail.com added a parent revision: D5087: hyperv/vmbus: malloc a buffer of PAGE_SIZE is grantee physical contig..Jan 29 2016, 2:38 PM
howard0su_gmail.com added a reviewer: adrian.Feb 4 2016, 4:49 AM
adrian accepted this revision.Feb 4 2016, 5:52 AM
adrian edited edge metadata.

i'm going to OK this, but when changing things to M_WAITOK, just make sure you run it on -HEAD with WITNESS and other debugging enabled (which it is by default, so don't disable it.)

Thanks!

This revision is now accepted and ready to land.Feb 4 2016, 5:52 AM
howard0su_gmail.com added a comment.Feb 4 2016, 7:03 AM

Yes. i already running HEAD with WITNESS with the change.

Closed by commit rS295308: hyperv: Use WAITOK in the places where we can wait (authored by sephe). · Explain WhyFeb 5 2016, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
netvsc/
17 lines
24 lines
vmbus/
44 lines
6 lines
14 lines

Diff 13046

View Options

head/sys/dev/hyperv/netvsc/hv_net_vsc.c

Loading...
View Options

head/sys/dev/hyperv/netvsc/hv_rndis_filter.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_connection.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_hv.c

Loading...
View Options

head/sys/dev/hyperv/vmbus/hv_vmbus_drv_freebsd.c

Loading...