Page MenuHomeFreeBSD

Hyperv: netvsc: Set net_dev's recv buffer size according to NVSP protocol version
ClosedPublic

Authored by honzhan_microsoft.com on Jan 7 2016, 10:56 AM.
Tags
None
Referenced Files
F106311364: D4814.id12284.diff
Sat, Dec 28, 1:08 PM
Unknown Object (File)
Sun, Dec 1, 3:23 AM
Unknown Object (File)
Nov 3 2024, 10:56 PM
Unknown Object (File)
Oct 19 2024, 10:09 AM
Unknown Object (File)
Oct 17 2024, 11:54 AM
Unknown Object (File)
Oct 2 2024, 6:33 PM
Unknown Object (File)
Oct 2 2024, 4:34 AM
Unknown Object (File)
Sep 22 2024, 5:15 PM
Subscribers

Details

Summary

If the NVSP protocol version is not greater than NVSP_PROTOCOL_VERSION_2, then
the recv buffer size is 15MB, otherwise the buffer size is 16MB.

Submitted by: Hongjiang Zhang <honzhan microsoft com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

honzhan_microsoft.com retitled this revision from to Hyperv: netvsc: Set net_dev's recv buffer size according to NVSP protocol version.
honzhan_microsoft.com updated this object.
This revision is now accepted and ready to land.Jan 11 2016, 8:36 AM
royger edited edge metadata.

I don't mind committing this, but is it really worth it? I mean, with 16MB you are always on the safe side, and it's not like 1MB of memory is a huge deal this days...

I don't mind committing this, but is it really worth it? I mean, with 16MB you are always on the safe side, and it's not like 1MB of memory is a huge deal this days...

It's only to cope with a host bug of Hyper-V 2008R2 -- on this old host, we need to use a slightly smaller receive buffer size, otherwise the buffer will not be accepted by the host.

adrian added a reviewer: adrian.
This revision was automatically updated to reflect the committed changes.