Page MenuHomeFreeBSD
Differential D5085

hyperv/hn: Avoid duplicate csum features settings
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Jan 27 2016, 7:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 12, 4:22 AM
Unknown Object (File)
Thu, Sep 10, 7:46 AM
Unknown Object (File)
Thu, Sep 10, 3:13 AM
Unknown Object (File)
Mon, Sep 7, 12:27 AM
Unknown Object (File)
Sun, Sep 6, 3:58 PM
Unknown Object (File)
Sat, Sep 5, 5:55 AM
Unknown Object (File)
Thu, Sep 3, 3:38 AM
Unknown Object (File)
Wed, Sep 2, 5:34 PM
View All Files
Subscribers
freebsd-net-list

Details

Reviewers
howard0su_gmail.com
honzhan_microsoft.com
decui_microsoft.com
delphij
royger
adrian
Group Reviewers
network
Commits
rS295296: hyperv/hn: Avoid duplicate csum features settings
Summary
  • Record csum features in softc, so we don't need to duplicate the logic from attach path to ioctl path.
  • Protect if_capenable and if_hwassist changes by main lock.
  • Prefer turn on/off bits in if_hwassist explicitly instead of using XOR.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 12744.Jan 27 2016, 7:02 AM
sepherosa_gmail.com retitled this revision from to hyperv/hn: Avoid duplicate csum features settings.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com.
sepherosa_gmail.com added a subscriber: freebsd-net-list.
honzhan_microsoft.com accepted this revision.Jan 28 2016, 7:58 AM
honzhan_microsoft.com edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 28 2016, 7:58 AM
adrian accepted this revision.Jan 28 2016, 5:06 PM
adrian edited edge metadata.
Closed by commit rS295296: hyperv/hn: Avoid duplicate csum features settings (authored by sephe). · Explain WhyFeb 5 2016, 4:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hyperv/
netvsc/
2 lines
64 lines

Diff 13030

View Options

head/sys/dev/hyperv/netvsc/hv_net_vsc.h

Loading...
View Options

head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c

Loading...