missing file to remove

Delete old patches from wxPython30

rebase

In D21915#522759, @lbartoletti_tuxfamily.org wrote:

My biggest fear with svn :)
How to be sure? I see that x11-toolkits/py-wxPython40 is copied from x11-toolkits/py-wxPython30. OK, but I deleted useless patches [1] and are not marked as deleted

[1] files/patch-src_gtk_propgridwrap.cpp, files/patch-src_gtk_gdi__wrap.cpp, files/patch-setup.py

In D21915#522637, @tcberner wrote:

Looks good to me. Make sure to include

Exp-run by: antoine

Looks good to me. Make sure to include

exp-run looks fine https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241893#c13

Fix my mail adress

Bump portversion for graphics/djvusmooth

Bump portversion for all ports which require wxPython40

Replace LIB_DEPENDS to USE_WX for graphics/djvusmooth

Update comms/congruity and graphics/py-mayavi to USE_WX=3.0+

Bump portversion emulators/playonbsd

bump portversion for cad/kicad and cad/kicad-devel

Fix cad/kicad-devel

Bump portrevision for audio/py-karaoke

Fix build for audio/py-karaoke. Use wxgtk-2.8

• Update Mk/bsd.wx.mk to use x11-toolkits/py-wxPython40 for wxWidgets 3.0
• While I'm here fix stagging for emulators/playonbsd
• Fix Makefile for cad/kicad (explicitly use wxPyton40 aka Phoenix)

Fix stripcmd. Thanks koobs@

gentle ping koobs@

New diff:

If this is a copy of an existing port, create the new port using svn copy (as this is what committers will have to do). Also have the benefits of that copy being tracked and displayed in the phabricator differential, and showing the diffs to the original source (so we know whats been updated/changed, rather than everything being new)

Fix pkg-descr

In D16378#349810, @dbn wrote:

FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)

FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)

LGTM

Remove unnecessary version check for FreeBSD < 10

The comments I mention are just suggestions. Happy for you to commit this patch without those changes.

Remove another unrelated patch that was accidentally slipped in

Does the change pass QA (poudriere) on supported/expected FreeBSD versions/archs without regression?

looks good to me.

Done.

Take maintainership and slightly modify pkg-message.

Add in pkg-message file.

I am marking those are "Done" since the subject was already discussed.

Built and installed naively it refuses to run until I set LANG to a UTF-8 locale (e.g. en_US.UTF-8), but that's more a Python 3.6 / Click problem than khal.

OK by me, but I'd still need an OK from @tcberner or @rakuco to commit it (or they could do it themselves).

There is one already.

In D13432#290787, @lbdm_privacychain.ch wrote:

Can it be merged already? :-)

Thanks!

Can it be merged already? :-)

Re-working install phase.

In D13432#285854, @adridg wrote:

Please double-check upstream's comment about setup.cfg.

Please double-check upstream's comment about setup.cfg.

Fixing manual file.

I'll have a look at this later, I'll keep track of this in khal's issue tracker (see https://github.com/pimutils/khal/issues/745 ).

In D13432#285348, @github_lostpackets.de wrote:

There are two different kind of errors here:

1. the filesystem of the build service doesn't seem to support mtime of files, while we could mock this, it's kind of the point to test if an updated file is caught my khal. Do you know what kind of system the build is run on?
2. the locale seems to be not/misconfigured, exporting the correct locale settings should fix those errors, something like exporting LC_ALL=en_US.utf-8 and LANG=en_US.utf-8 should do the tick ( see http://click.pocoo.org/5/python3/#python-3-surrogate-handling )

As the first issue is not easily fixable, I would suggest either patching the tests to make them xfail or not run them for now.

Removing TEST. The inclusion was making the things too cumbersome.

There are two different kind of errors here:

Minor.

I completely forgot about the PKGNAMEPREFIX.

One more thing you can expect python@ team to bring up is [1], specifically PKGNAMEPREFIX missing and the port being named net-p2p/py-tremc. Not sure if it needs to follow these policies though because its not a standard python port.

Updating distinfo.

Done.
Thanks!

Fixing.

Building fine now.

Fix typo in GEOIP_RUN_DEPENS.