Page MenuHomeFreeBSD

New port: net-p2p/py-tremc.
ClosedPublic

Authored by rigoletto on Dec 25 2017, 3:46 PM.

Details

Summary

This is a CLI transmission client. A python:3 fork (of the now abbandoned) transmission-remote-cli.

Test Plan

I am experiencing a weird behaviour while building this port with the XEROX (devel/py-xerox) option ON:

1 - if devel/py-xerox is already installed while building this port, make build it again and later fail due to devel/py-xerox
already being installed;

2 - if devel/py-xerox is not installed, make build it and later make fail with "tremc-20171202 depends on executable:
py36-xerox - not found". Same happens with Poudriere builds.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rigoletto edited the test plan for this revision. (Show Details)
rigoletto retitled this revision from New port net-p2p/tremc. to New port: net-p2p/tremc..Dec 25 2017, 3:52 PM

Fix typo in GEOIP_RUN_DEPENS.

Building fine now.

Thanks! :)

ultima added inline comments.
net-p2p/tremc/Makefile
4 ↗(On Diff #37028)

Using USE_GITHUB When Upstream Does Not Use Versions should have g followed by the date.

example: g20171202

5 ↗(On Diff #37028)

why the "?"?

30 ↗(On Diff #37028)

Mk/bsd.options.desc.mk already has the correct description. This can be removed.

rigoletto marked 3 inline comments as done.

Fixing.

One more thing you can expect python@ team to bring up is [1], specifically PKGNAMEPREFIX missing and the port being named net-p2p/py-tremc. Not sure if it needs to follow these policies though because its not a standard python port.

[1] https://wiki.freebsd.org/Python/PortsPolicy

I completely forgot about the PKGNAMEPREFIX.

Fixing.
Thanks!

rigoletto retitled this revision from New port: net-p2p/tremc. to New port: net-p2p/py-tremc..Dec 26 2017, 3:32 PM
net-p2p/py-tremc/Makefile
26 ↗(On Diff #37050)

This should be man/man1/tremc.1.gz

net-p2p/py-tremc/Makefile
36–38 ↗(On Diff #37166)
  1. I do not think this is needed, the framework will compress the man pages automatically
  2. This does not belong in the "patch" phase.
rigoletto marked an inline comment as done.

Re-working install phase.

This revision is now accepted and ready to land.Dec 30 2017, 8:21 PM
This revision was automatically updated to reflect the committed changes.