I see that there was no feedback from gnome@ (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281309) so Approved by: maintainer timeout applies.

Committed in https://cgit.freebsd.org/src/commit/?id=6fa42b91ca3f481912af98c4d49c44507eb1b8e1

Thanks!

Thanks!

Incorporate Mark's feedback

I've added you, @imp, to the reviewers of this change as you usually have smart things to say about things related to the culture of the project ;) I hope you don't mind.

I think this patch is a fair workaround for the issues reported in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223132.

In D46924#1072191, @gshapiro wrote:

In D46924#1072046, @markj wrote:

What exactly is the effect? Does sendmail actually need the shutdown keyword?

Yes, to ensure a clean shutdown of active SMTP connections (and writing any in memory queue files).

Thanks! I've updated the patch with the suggestions.

Incorporate kib's feedback.

Incorporate feedback

Looks good. Just a couple of nits.

Thank you!

2 minor requests. Otherwise, the manual change looks OK.

I'll wait for @bnovkov before pushing this one ;)

The manual page update and release notes may go in another revision.

We'll need to update the manual page as well. I could do that :)

And the features got documented in 81b9905234e34a778dd524385279c2a807d83308...

This is a stopgap. A proper fix would require a rewrite of this service script and possibly a split of the different functionalities of this script into separate files.