Page MenuHomeFreeBSD

rc.d/sendmail: Fix the rcorder block
ClosedPublic

Authored by 0mp on Oct 4 2024, 12:29 PM.
Tags
Referenced Files
F157150218: D46924.diff
Mon, May 18, 7:22 PM
F157150207: D46924.diff
Mon, May 18, 7:22 PM
F157150177: D46924.diff
Mon, May 18, 7:22 PM
F157093004: D46924.diff
Mon, May 18, 9:58 AM
F157057370: D46924.id.diff
Mon, May 18, 4:48 AM
Unknown Object (File)
Sat, May 16, 11:38 PM
Unknown Object (File)
Sat, May 16, 11:38 PM
Unknown Object (File)
Sat, May 16, 11:37 PM
Subscribers

Details

Summary

rcorder(8) requires the rcorder block to be an uninterrupted sequence of
REQUIRE, PROVIDE, BEFORE, and KEYWORD lines. Having a comment in between
REQUIRE and KEYWORD makes rcorder stop parsing the block when it reaches
the comment. Fix that by moving the comment out from the rcorder block.

MFC after: 3 days

Test Plan

After the patch is applied, rcorder will report sendmail as having the shutdown keyword:

rcorder -k shutdown /etc/rc.d/* | grep sendmail

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested review of this revision.Oct 4 2024, 12:29 PM
0mp added reviewers: bnovkov, christos, markj.
0mp added a project: rc.

This seems fine to me. Looks like it's been broken for a rather long time.

What exactly is the effect? Does sendmail actually need the shutdown keyword?

This revision is now accepted and ready to land.Oct 9 2024, 3:20 PM

What exactly is the effect? Does sendmail actually need the shutdown keyword?

Yes, to ensure a clean shutdown of active SMTP connections (and writing any in memory queue files).

What exactly is the effect? Does sendmail actually need the shutdown keyword?

Yes, to ensure a clean shutdown of active SMTP connections (and writing any in memory queue files).

Great info! Thanks!