Page MenuHomeFreeBSD
Feed Advanced Search

Mar 22 2024

emaste requested review of D44473: rights.4: add note about rights not being simple bitmasks.
Mar 22 2024, 1:48 PM
emaste committed rG95a7c6f18a6a: LinuxKPI: Queue skbuffs at tail in __skb_queue_tail (authored by tom_coldrick.cc).
LinuxKPI: Queue skbuffs at tail in __skb_queue_tail
Mar 22 2024, 1:39 PM
emaste committed rG35457886cd3a: release: remove binutils package data (authored by emaste).
release: remove binutils package data
Mar 22 2024, 1:39 PM
emaste committed rGa2ef45a0656f: rights.4: Remove sentence implying that rights are a mask (authored by emaste).
rights.4: Remove sentence implying that rights are a mask
Mar 22 2024, 1:38 PM
emaste committed rGe8d01b2efaa3: path_test: fix cap_rights_init usage (authored by emaste).
path_test: fix cap_rights_init usage
Mar 22 2024, 1:38 PM
emaste committed rGec44cc4e2882: libcasper: fix cap_rights_init usage (authored by emaste).
libcasper: fix cap_rights_init usage
Mar 22 2024, 1:38 PM
emaste committed rG8a17cc127bb0: cat: fix cap_rights_init usage (authored by emaste).
cat: fix cap_rights_init usage
Mar 22 2024, 1:37 PM
emaste committed rG1abd98ecf9e3: cat: add CAP_SEEK capability (authored by oshogbo).
cat: add CAP_SEEK capability
Mar 22 2024, 1:37 PM
emaste committed rG5f527dbe41b8: cat: add CAP_SEEK capability (authored by oshogbo).
cat: add CAP_SEEK capability
Mar 22 2024, 1:35 PM
emaste committed rG2031b368f895: rights.4: Remove sentence implying that rights are a mask (authored by emaste).
rights.4: Remove sentence implying that rights are a mask
Mar 22 2024, 1:35 PM
emaste committed rGea3910c452cf: path_test: fix cap_rights_init usage (authored by emaste).
path_test: fix cap_rights_init usage
Mar 22 2024, 1:35 PM
emaste committed rGbe83aa2a01b3: libcasper: fix cap_rights_init usage (authored by emaste).
libcasper: fix cap_rights_init usage
Mar 22 2024, 1:35 PM
emaste committed rGdbf34bbb1888: cat: fix cap_rights_init usage (authored by emaste).
cat: fix cap_rights_init usage
Mar 22 2024, 1:35 PM
emaste committed rGb5ae8f217122: ccdconfig: remove obsolete references to BSD disklabels (authored by emaste).
ccdconfig: remove obsolete references to BSD disklabels
Mar 22 2024, 1:35 PM
emaste committed rG269bc49fba66: style.lua.9: remove mention of $FreeBSD$ (authored by emaste).
style.lua.9: remove mention of $FreeBSD$
Mar 22 2024, 1:35 PM
emaste committed rG144abdaa2bdd: wlan(4) - remove an(4) reference (authored by christopher.davidson_gmail.com).
wlan(4) - remove an(4) reference
Mar 22 2024, 1:35 PM
emaste committed rG466e0dc5ce78: random(9): bump removal to FreeBSD 15.0 (authored by emaste).
random(9): bump removal to FreeBSD 15.0
Mar 22 2024, 1:34 PM
emaste committed rGed70dd5bf560: iwm.4: add iwlwifi cross-reference (authored by emaste).
iwm.4: add iwlwifi cross-reference
Mar 22 2024, 1:34 PM
emaste committed rG1bc20e8af16c: mount: document atime option (authored by emaste).
mount: document atime option
Mar 22 2024, 1:33 PM
emaste committed rGc3c75c142c0c: open: make non-POSIX errno value more apparent (authored by emaste).
open: make non-POSIX errno value more apparent
Mar 22 2024, 1:33 PM
emaste committed rG0416bffd5183: CONTRIBUTING.md: fix typo from commmit to commit (authored by rilysh <nightquick@proton.me>).
CONTRIBUTING.md: fix typo from commmit to commit
Mar 22 2024, 1:33 PM
emaste committed rG67e6b8354a7b: CONTRIBUTING.md: add author identity info (authored by emaste).
CONTRIBUTING.md: add author identity info
Mar 22 2024, 1:12 PM

Mar 21 2024

emaste accepted D44092: build: add Wswitch to clang for more consistency with gcc.
Mar 21 2024, 3:48 PM

Mar 20 2024

emaste added a comment to D44440: BSD.usr.dist: remove empty /usr/libdata/gcc directory.

We don't need these, they were just forgotten when GCC was removed.

Mar 20 2024, 6:06 PM
emaste accepted D44440: BSD.usr.dist: remove empty /usr/libdata/gcc directory.

It came from rG:2bb58cb2e0c46298578b02d4448f69e4de166f16 and indeed is not used.
You could bump .Dd in hier.7 if you are so inclined.

Mar 20 2024, 5:50 PM
emaste accepted D44438: kassert.h: update MPASS definition commentary.
Mar 20 2024, 3:39 PM
emaste accepted D44439: KASSERT(9): describe history of MPASS.
Mar 20 2024, 3:00 PM
emaste accepted D44434: KASSERT(9): add assertion message guidelines.
Mar 20 2024, 2:59 PM
emaste accepted D44436: ds1307: use the correct Microchip part number in enum and device description.
Mar 20 2024, 12:40 PM
emaste added inline comments to D44302: diff: Integrate libdiff from OpenBSD GoT..
Mar 20 2024, 11:47 AM

Mar 19 2024

emaste added a comment to D43712: vmxnet3: make descriptor count checks more robust.

LGTM

Mar 19 2024, 6:27 PM
emaste added inline comments to D44434: KASSERT(9): add assertion message guidelines.
Mar 19 2024, 6:10 PM
emaste accepted D44434: KASSERT(9): add assertion message guidelines.

This looks good to me

Mar 19 2024, 6:09 PM
emaste accepted D44331: msun/riscv: limit exposure of fegetexcept.

OK but I agree with jhb that skipping ahead to removal is fine

Mar 19 2024, 5:13 PM
emaste accepted D44276: cross build: symlink diff and objdump.

As with D44275 no objection but perhaps nm and/or readelf are suitable?

Mar 19 2024, 5:06 PM
emaste accepted D44275: Restore ${OBJDUMP}.

A future commit will use objdump to compare the set of symbols built in libraries with a reference list.

Mar 19 2024, 5:05 PM
emaste closed D42722: handbook: update current version before freebsd-upgrade.
Mar 19 2024, 2:52 PM
emaste committed R9:1fcf388d7d2f: handbook: update current version before freebsd-upgrade (authored by emaste).
handbook: update current version before freebsd-upgrade
Mar 19 2024, 2:52 PM
emaste requested review of D44433: fma: correct zero sign with small inputs.
Mar 19 2024, 2:34 PM

Mar 18 2024

emaste added a comment to D44411: sound: Get rid of snd_clone and use DEVFS_CDEVPRIV(9).

We should update sound(4) to indicate that /dev/dspX.Y are deprecated and will be removed, not just strongly discouraged. That said, we don't list /dev/dsp or /dev/dsp0 in sound(4) right now, only /dev/dsp%d.%d and related. We should add those, and probably also find a better representation than printf's %d

Mar 18 2024, 8:31 PM
emaste committed rGf50322c1dcfe: random(9): bump removal to FreeBSD 15.0 (authored by emaste).
random(9): bump removal to FreeBSD 15.0
Mar 18 2024, 8:05 PM
emaste committed rGe600fc7295a7: ssh: remove deprecated client VersionAddendum (authored by emaste).
ssh: remove deprecated client VersionAddendum
Mar 18 2024, 2:20 PM
emaste committed rGa91a246563df: ssh: Update to OpenSSH 9.7p1 (authored by emaste).
ssh: Update to OpenSSH 9.7p1
Mar 18 2024, 2:02 PM

Mar 17 2024

emaste committed rG9200ce3210fd: Vendor import of OpenSSH 9.7p1 (authored by emaste).
Vendor import of OpenSSH 9.7p1
Mar 17 2024, 5:49 PM
emaste accepted D44356: freebsd-update: mark "cron" as fetched as "fetch" itself.
Mar 17 2024, 3:05 PM
emaste added inline comments to D44374: pkgbase: rework certctl package to only run rehash on the main package.
Mar 17 2024, 1:38 PM
emaste accepted D43700: freebsd-update: Don't provide copiable commands in output.
Mar 17 2024, 12:18 PM
emaste committed rG1e4cd5ed54d7: release: remove binutils package data (authored by emaste).
release: remove binutils package data
Mar 17 2024, 12:15 PM
emaste accepted D44369: release: add basic cloudinit images.

I'd like to reduce the duplication in the cloud image *.conf files but that's not specific to this addition.

Mar 17 2024, 12:02 PM

Mar 5 2024

emaste added a comment to D44216: Make WITHOUT_UNDEFINED_VERSION the default.

This is successful everywhere (i.e. architectures, discounting conflicts with other options that Michael Dexter's option survey will find)?

Mar 5 2024, 1:09 AM

Mar 4 2024

emaste closed D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.
Mar 4 2024, 2:35 PM · linuxkpi
emaste committed rGd3befb534b9c: LinuxKPI: Queue skbuffs at tail in __skb_queue_tail (authored by tom_coldrick.cc).
LinuxKPI: Queue skbuffs at tail in __skb_queue_tail
Mar 4 2024, 2:35 PM

Mar 3 2024

emaste accepted D44195: Add POSIX_SPAWN_DISABLE_ASLR_NP.

I'm not 100% certain about the name (_NP suffix vs Apple's _ prefix) but that can always be dealt with later.
I see qnx offers a posix_spawnattr_setaslr(), as well as (bizarrely) POSIX_SPAWN_ASLR_INVERT which toggles the state for the child.

Mar 3 2024, 3:54 PM
emaste added inline comments to D44190: 13.3 relnotes: last-minute updates.
Mar 3 2024, 12:59 AM
emaste accepted D44193: imgact_elf: Add const to the header_supported callback arguments.
Mar 3 2024, 12:16 AM

Mar 2 2024

emaste added a comment to D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.

@bz thanks, commit subject line and Reviewed-by's updated.

Mar 2 2024, 10:07 PM · linuxkpi
emaste updated subscribers of D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.
Mar 2 2024, 7:32 PM · linuxkpi
emaste added a comment to D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.

Now in my staging tree as:

Mar 2 2024, 7:27 PM · linuxkpi
emaste accepted D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.
Mar 2 2024, 7:21 PM · linuxkpi
emaste added a comment to D44192: linuxkpi: Queue skbuffs at tail in skb_queue_tail.

FYI, please generate diffs for reviews with full context e.g. git diff -U999999 or git show -U999999 so that Phabricator will display the additional context on demand. See https://wiki.freebsd.org/Phabricator for more info.

Mar 2 2024, 6:43 PM · linuxkpi
emaste committed rG42b117a4bd10: gpioevents: Fix build with newer Clang (authored by John F. Carr <jfc@mit.edu>).
gpioevents: Fix build with newer Clang
Mar 2 2024, 3:40 PM

Mar 1 2024

emaste accepted D44169: Add an UNDEFINED_VERSION option.
Mar 1 2024, 6:30 PM
emaste added inline comments to D44169: Add an UNDEFINED_VERSION option.
Mar 1 2024, 5:27 PM
emaste committed rG24235654f104: Cirrus-CI: Add manual Clang 18 jobs (authored by emaste).
Cirrus-CI: Add manual Clang 18 jobs
Mar 1 2024, 4:49 PM
emaste committed rG51c6bf0478bd: Cirrus-CI: bump Clang versions to 16 and 17 (authored by emaste).
Cirrus-CI: bump Clang versions to 16 and 17
Mar 1 2024, 1:13 AM
emaste closed D44162: Cirrus-CI: bump Clang versions to 17 and 18.
Mar 1 2024, 1:13 AM

Feb 29 2024

emaste updated the diff for D44162: Cirrus-CI: bump Clang versions to 17 and 18.

Use 16 and 17 for now, 18 gave me pkg: No packages available to install matching 'llvm18-lite' have been found in the repositories. Will replace 16 with 18 later.

Feb 29 2024, 11:01 PM
emaste requested review of D44162: Cirrus-CI: bump Clang versions to 17 and 18.
Feb 29 2024, 10:06 PM
emaste accepted D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
emaste added inline comments to D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
emaste committed rG784695750ef3: jail: Fix information leak. (authored by pjd).
jail: Fix information leak.
Feb 29 2024, 1:18 PM
emaste committed rG814761540eb9: kern: fix panic with disabled ttys (authored by emaste).
kern: fix panic with disabled ttys
Feb 29 2024, 1:18 PM
emaste accepted D44136: rtld: unconditionally generate map file during build.

Thanks, this makes it more clear why we do this.

Feb 29 2024, 12:33 AM
emaste committed rGa60220bbb551: kern: fix panic with disabled ttys (authored by emaste).
kern: fix panic with disabled ttys
Feb 29 2024, 12:31 AM
emaste committed rG8d22744f5be1: kern: fix panic with disabled ttys (authored by emaste).
kern: fix panic with disabled ttys
Feb 29 2024, 12:30 AM

Feb 28 2024

emaste accepted D3392: usbconfig: allow to get usb vendors and products from the usb.ids database.
Feb 28 2024, 7:00 PM
emaste added inline comments to D44141: nuageinit: add basic support for cloudinit..
Feb 28 2024, 6:14 PM
emaste added inline comments to D43254: libc: Remove support for pre-C11 C standards.
Feb 28 2024, 3:57 PM · Contributor Reviews (src)
emaste added a comment to D43700: freebsd-update: Don't provide copiable commands in output.

What do you think about something like Run 'freebsd-update [options] install' to proceed? It offers a reminder to include the user's necessary options but retains the example style.

Feb 28 2024, 3:11 PM
emaste accepted D43237: Use gnu17 for buildworld.
Feb 28 2024, 2:54 PM · Contributor Reviews (src)
emaste accepted D43242: rc.initdiskless: Disable soft-updates in mdmfs (again).
Feb 28 2024, 2:52 PM
emaste added a comment to D44072: kernel: Add new dwarf symbols.

s/Macey/Macy/

Feb 28 2024, 2:49 PM
emaste accepted D43976: arm64: Rename drop_to_el1 to enter_kernel_el.
Feb 28 2024, 2:45 PM
emaste added a comment to D43873: build: Do not run ctfconvert on VDSO files.

This was committed (accidentally referencing D43877) and can be closed.

Feb 28 2024, 2:44 PM
emaste accepted D44136: rtld: unconditionally generate map file during build.

No objection but I would suggest changing the commit message slightly -- right now it seems to imply that the mere presence of the map file prevents undesired libc/libsys code into rtld, rather than just always having the map file available for the developer to inspect. Or just a comment before the LDFLAGS entry, something like

Feb 28 2024, 1:54 PM
emaste accepted D44135: lorder: Undeprecate..
Feb 28 2024, 1:21 PM
emaste added a comment to D44135: lorder: Undeprecate..

What do you think about a comment explaining why it is retained? something like "is not required by contemporary linkers, but it is still expected by some third party software build systems."

Feb 28 2024, 2:43 AM

Feb 27 2024

emaste added inline comments to D44128: new-bus: Remove the 'type' argument from BUS_ADJUST_RESOURCE.
Feb 27 2024, 7:53 PM
emaste added inline comments to D3392: usbconfig: allow to get usb vendors and products from the usb.ids database.
Feb 27 2024, 5:59 PM
emaste added inline comments to D43940: Update for bhyve.8 man page.
Feb 27 2024, 2:49 PM · manpages, docs
emaste added inline comments to D44041: lldb lua: Add some helper functions to deal with netinet.
Feb 27 2024, 2:39 PM
emaste added a comment to D44041: lldb lua: Add some helper functions to deal with netinet.

starting off with this in tools/ makes sense, but we probably want to install them at some point, perhaps making use of them in /usr/sbin/crashinfo.

Feb 27 2024, 2:36 PM
emaste abandoned D44091: pam_xdg: check for error from asprintf.

Done by @manu in 2d2950c889335b24af7a92f3aaf9946de47bb0bc

Feb 27 2024, 1:33 PM

Feb 26 2024

emaste added inline comments to D44078: Update to FreeBSD handbook: virtualization chapter.
Feb 26 2024, 11:40 PM · docs
emaste added inline comments to D43948: Update to FreeBSD handbook: disks chapter (plus advanced-networking cleanup).
Feb 26 2024, 11:37 PM · docs
emaste committed rG26db5b3e638e: Remove MOVED_LIBS handling from list-old-libs (authored by emaste).
Remove MOVED_LIBS handling from list-old-libs
Feb 26 2024, 11:18 PM
emaste added a comment to D44092: build: add Wswitch to clang for more consistency with gcc.

Makes sense to me. Have you tested make tinderbox?

Feb 26 2024, 8:54 PM
emaste closed D44086: Fix kernel panic with disabled ttys.
Feb 26 2024, 8:14 PM
emaste committed rG975d7730828a: kern: fix panic with disabled ttys (authored by emaste).
kern: fix panic with disabled ttys
Feb 26 2024, 8:14 PM
emaste requested review of D44091: pam_xdg: check for error from asprintf.
Feb 26 2024, 7:32 PM