It is needed at least to ensure that undesirable code is not linked into rtld from libsys/libc, and adding the map file option each time is not productive.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
No objection but I would suggest changing the commit message slightly -- right now it seems to imply that the mere presence of the map file prevents undesired libc/libsys code into rtld, rather than just always having the map file available for the developer to inspect. Or just a comment before the LDFLAGS entry, something like
# Always produce the map file so that may be inspected to confirm undesired # code is not linked from libsys/libc.
Comment Actions
Thanks, this makes it more clear why we do this.
You may want to redirect error messages to stderr.