Page MenuHomeFreeBSD

rtld: unconditionally generate map file during build
ClosedPublic

Authored by kib on Feb 28 2024, 1:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 31, 6:53 AM
Unknown Object (File)
Wed, May 29, 12:29 AM
Unknown Object (File)
Sat, May 25, 11:02 PM
Unknown Object (File)
Sat, May 25, 2:00 PM
Unknown Object (File)
Fri, May 24, 7:18 PM
Unknown Object (File)
Fri, May 24, 5:46 PM
Unknown Object (File)
Wed, May 22, 2:05 AM
Unknown Object (File)
Sun, May 19, 3:03 AM
Subscribers

Details

Summary
It is needed at least to ensure that undesirable code is not linked into
rtld from libsys/libc, and adding the map file option each time is not
productive.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Feb 28 2024, 1:15 AM

No objection but I would suggest changing the commit message slightly -- right now it seems to imply that the mere presence of the map file prevents undesired libc/libsys code into rtld, rather than just always having the map file available for the developer to inspect. Or just a comment before the LDFLAGS entry, something like

# Always produce the map file so that may be inspected to confirm undesired
# code is not linked from libsys/libc.
This revision is now accepted and ready to land.Feb 28 2024, 1:54 PM

Incorporate suggested comment.
Automate some checks I intended to have.

This revision now requires review to proceed.Feb 28 2024, 11:43 PM
This revision is now accepted and ready to land.Feb 29 2024, 12:24 AM

Thanks, this makes it more clear why we do this.

You may want to redirect error messages to stderr.