Page MenuHomeFreeBSD
Differential D44438

kassert.h: update MPASS definition commentary
ClosedPublic
Actions

Authored by mhorne on Mar 20 2024, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:10 AM
Unknown Object (File)
Mon, Apr 15, 1:17 AM
Unknown Object (File)
Mar 21 2024, 5:47 PM
Subscribers
imp

Details

Reviewers
bz
emaste
Commits
rG0c62a06b84ab: kassert.h: update MPASS definition commentary
rG36de8bb22667: kassert.h: update MPASS definition commentary
Summary

We now have a detailed man page describing both MPASS and KASSERT. Give
a warning that careless use of MPASS can result in inadequate assertion
messages, and point to the MPASS(9) page which describes this.

While here add a comment above the KASSERT definitions pointing to the
man page.

Suggested by: bz

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Mar 20 2024, 2:41 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 20 2024, 2:41 PM
mhorne requested review of this revision.Mar 20 2024, 2:41 PM
Harbormaster completed remote builds in B56708: Diff 135988.Mar 20 2024, 2:41 PM
mhorne mentioned this in D44434: KASSERT(9): add assertion message guidelines.Mar 20 2024, 2:43 PM
emaste accepted this revision.Mar 20 2024, 3:39 PM
emaste added inline comments.
sys/sys/kassert.h
162

I'm not a fan of XXX for use other than "this is wrong/broken/needs to be revisited". Maybe NOTE?

This revision is now accepted and ready to land.Mar 20 2024, 3:39 PM
imp added inline comments.Mar 20 2024, 4:01 PM
sys/sys/kassert.h
162

Xxx is ok in our code, but i agree with NOTE: to make it more accessible.

Closed by commit rG36de8bb22667: kassert.h: update MPASS definition commentary (authored by mhorne). · Explain WhyMar 21 2024, 3:26 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG36de8bb22667: kassert.h: update MPASS definition commentary.
mhorne added a commit: rG0c62a06b84ab: kassert.h: update MPASS definition commentary.Thu, Apr 18, 6:20 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
10 lines

Diff 136043

View Options

sys/sys/kassert.h

Loading...