Page MenuHomeFreeBSD
Feed Advanced Search

Jan 30 2024

karels committed rG0c6e3bfd1362: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images (authored by karels).
arm64/RPI: enable powerd by default on arm64-aarch64-RPI images
Jan 30 2024, 8:11 PM

Jan 27 2024

karels committed rG9231c42127bf: inet(3): clarify syntax accepted by inet_pton (authored by karels).
inet(3): clarify syntax accepted by inet_pton
Jan 27 2024, 3:41 PM
karels closed D43537: inet(3): clarify syntax accepted by inet_pton.
Jan 27 2024, 3:41 PM
karels added a comment to D43537: inet(3): clarify syntax accepted by inet_pton.

Anyone from manpages want to approve this?

Jan 27 2024, 3:22 PM

Jan 23 2024

karels committed rG2e68c5a44c40: tmpfs: increase vfs.tmpfs.memory_percent to 100 as workaround (authored by karels).
tmpfs: increase vfs.tmpfs.memory_percent to 100 as workaround
Jan 23 2024, 6:47 PM
karels accepted D42773: CDs are not usable anymore.

Looks good, I can approve for releng; someone from docs should approve, though, and commit if necessary.

Jan 23 2024, 4:59 PM · docs

Jan 22 2024

karels committed rG74e52718aa73: route: error on IPv4 network routes with incorrect destination (authored by karels).
route: error on IPv4 network routes with incorrect destination
Jan 22 2024, 4:44 PM
karels committed rG7e88d8fec4e8: route: error on IPv4 network routes with incorrect destination (authored by karels).
route: error on IPv4 network routes with incorrect destination
Jan 22 2024, 4:43 PM

Jan 21 2024

karels requested review of D43537: inet(3): clarify syntax accepted by inet_pton.
Jan 21 2024, 7:45 PM

Jan 18 2024

karels accepted D42722: handbook: update current version before freebsd-upgrade.
Jan 18 2024, 11:28 PM

Jan 16 2024

karels added a comment to D43466: newsyslog(8): Remove -c command line option..
In D43466#990869, @olce wrote:
In D43466#990866, @dvl wrote:

I think you're saying why have a command-line switch when we have the in-conf-file option?

I was just trying to guess the reasoning for the removal of this command-line option, by stating one possible inference, since I anticipate that the use of -c is infrequent and it's always possible for the administrator to change the configuration file (well, I also can see situations where these are not equivalent...). Personally, I don't have a need to remove it, and at the same time I'll likely never use it, in that sense I'm neutral.

Jan 16 2024, 7:29 PM

Jan 15 2024

karels committed rGb9e8ae1d8a42: route: error on IPv4 network routes with incorrect destination (authored by karels).
route: error on IPv4 network routes with incorrect destination
Jan 15 2024, 9:16 PM
karels closed D43384: route: error on IPv4 network routes with incorrect destination.
Jan 15 2024, 9:15 PM
karels added inline comments to D43384: route: error on IPv4 network routes with incorrect destination.
Jan 15 2024, 9:10 PM
karels committed rGc10c15319676: Increase the size of riscv GENERICSD images to 6 GB (authored by karels).
Increase the size of riscv GENERICSD images to 6 GB
Jan 15 2024, 1:32 PM
karels committed rG9895c3a22783: Increase the size of riscv GENERICSD images to 6 GB (authored by karels).
Increase the size of riscv GENERICSD images to 6 GB
Jan 15 2024, 1:31 PM
karels committed rG6137b5f7b8c1: Increase the size of riscv GENERICSD images to 6 GB (authored by karels).
Increase the size of riscv GENERICSD images to 6 GB
Jan 15 2024, 1:31 PM

Jan 14 2024

karels added inline comments to D42773: CDs are not usable anymore.
Jan 14 2024, 7:48 PM · docs
karels updated the diff for D43384: route: error on IPv4 network routes with incorrect destination.

Use local variables to factor out parts of long expression, simplify

Jan 14 2024, 4:04 PM

Jan 11 2024

karels added a comment to D43384: route: error on IPv4 network routes with incorrect destination.

I tried formatting the check as a separate function, and that doesn't help much. The main part of the expression (computing the host part) still doesn't fit on one line. I think I'll leave it as it is.

Jan 11 2024, 11:38 PM
karels added a comment to D43384: route: error on IPv4 network routes with incorrect destination.

Any comments on this, including the plan to MFC? I didn't reply to Ed's comment on the bug about possibly erroring on 15, and restoring the workaround on 13 and 14,. But I think it will have been long enough since this "worked" that people will have gotten used to the new behavior unless they stick with 12.4 until 13.3 is out.

Jan 11 2024, 8:16 PM

Jan 9 2024

karels requested review of D43384: route: error on IPv4 network routes with incorrect destination.
Jan 9 2024, 9:14 PM

Jan 5 2024

karels committed rG4347ef60501f: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images (authored by karels).
arm64/RPI: enable powerd by default on arm64-aarch64-RPI images
Jan 5 2024, 7:42 PM
karels closed D43296: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images.
Jan 5 2024, 7:42 PM

Jan 4 2024

karels added a member for releng: karels.
Jan 4 2024, 1:59 PM

Jan 3 2024

karels added a comment to D43296: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images.

There is an alternative approach in https://reviews.freebsd.org/D43141. The main difference is that it splits RPI4 into a separate image, leaving RPI for RPi 3 etc. I don't think that is necessary, as noted in that review. The other difference is in using the quirks mechanism, which would require modification to be effective in this case.

Jan 3 2024, 9:39 PM
karels added a comment to D43141: Add powerd_enable for RPI4.

I put my change in review https://reviews.freebsd.org/D43296. Comments welcome.

Jan 3 2024, 9:35 PM · Contributor Reviews (src)
karels added a reviewer for D43296: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images: releng.
Jan 3 2024, 9:34 PM
karels requested review of D43296: arm64/RPI: enable powerd by default on arm64-aarch64-RPI images.
Jan 3 2024, 9:33 PM

Jan 1 2024

karels added a comment to D43141: Add powerd_enable for RPI4.

I spoke too soon. The quirk mechanism won't work here without other changes, as /etc/rc.conf is truncated after the quirk is called.

Jan 1 2024, 10:22 PM · Contributor Reviews (src)
karels added a comment to D43141: Add powerd_enable for RPI4.

I added the following comment to the bug:

Jan 1 2024, 10:12 PM · Contributor Reviews (src)

Dec 31 2023

karels added a comment to D43245: tcp: limit namespace for tcp_[gs]et_flags.

Moving the #endif might be worth mentioning in the description too; only TCP_NODELAY should be visible without __BSD_VISIBLE

Dec 31 2023, 3:14 PM
karels accepted D43245: tcp: limit namespace for tcp_[gs]et_flags.

Thanks for moving the #endif!

Dec 31 2023, 2:20 PM

Dec 30 2023

karels added a comment to D43245: tcp: limit namespace for tcp_[gs]et_flags.

There is another namespace issue in tcp.h. There have been several additions near the end of the file, after the #endif at line 458. The #endif closes the #ifdef _BSD_VISIBLE at line 181. The #endif should be moved to line 544, just before the closing #endif, as the additions are not in POSIX, and the #endif should be commented as /* _BSD_VISIBLE */ so people are less likely to add things after it. If you don't want to combine the namespace fixes, I can do it later.

Dec 30 2023, 4:32 PM

Dec 29 2023

karels added a comment to D43231: tcp: fix ports.

Most of netinet/tcp.h is already inside #ifdef __BSD_VISIBLE, so it would be "legal" to use tcp_[gs]et_flags. It would be better to avoid intruding into the BSD namespace, though, using __tcp_[gs]et_flags for user space, and providing aliases for the kernel. I can imagine network tools using these names.

Dec 29 2023, 10:08 PM
karels accepted D43227: Clarify that copy_file_range(2) only operates on regular file objects in copy_file_range.2.

Looks good to me.

Dec 29 2023, 2:27 AM

Dec 28 2023

karels added a comment to D43227: Clarify that copy_file_range(2) only operates on regular file objects in copy_file_range.2.

Oh, the title has a typo in the man page name.

Dec 28 2023, 11:45 PM
karels added a comment to D43227: Clarify that copy_file_range(2) only operates on regular file objects in copy_file_range.2.

The change seems reasonable to me. I marked a pre-existing nit that is probably worth fixing while in the area.

Dec 28 2023, 11:44 PM

Dec 25 2023

karels added a comment to D43174: newsyslog(8): Add support of specifying compression method in configuration file..

I think this is a step in the right direction (having the compression specified in the config file), but I think it needs better integration with the existing flags. For example, there could be a new flag selecting the default as specified with <compress>, replacing J in the default config file lines.

Dec 25 2023, 4:16 PM

Dec 22 2023

karels accepted D43163: Update exports.5 man page for handling of special characters in directory names.
Dec 22 2023, 2:08 AM
karels added inline comments to D43163: Update exports.5 man page for handling of special characters in directory names.
Dec 22 2023, 12:09 AM

Dec 19 2023

karels committed rG636592343c3e: tmpfs: increase memory reserve to a percent of available memory + swap (authored by karels).
tmpfs: increase memory reserve to a percent of available memory + swap
Dec 19 2023, 3:35 PM
karels committed rGed19c0989fe7: tmpfs: enforce size limit on writes when file system size is default (authored by karels).
tmpfs: enforce size limit on writes when file system size is default
Dec 19 2023, 3:35 PM
karels closed D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 19 2023, 3:34 PM
karels closed D43010: tmpfs: enforce size limit on writes when file system size is default.
Dec 19 2023, 3:34 PM
karels added inline comments to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 19 2023, 3:20 PM
karels added a comment to D43092: tcp_hpts: make the module unloadable.

Looks plausible to me, but I'll let someone more familiar with the code approve.

Dec 19 2023, 3:57 AM

Dec 17 2023

karels added a comment to D43010: tmpfs: enforce size limit on writes when file system size is default.

Any questions or comments on this review?

Dec 17 2023, 1:42 PM
karels updated the diff for D43011: tmpfs: increase memory reserve to a percent of available memory + swap.

Remove useless printf; fix typo in man page

Dec 17 2023, 1:40 PM

Dec 16 2023

karels added inline comments to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 16 2023, 6:23 PM

Dec 15 2023

karels accepted D42762: periodic: Make daily diff(1) output as small is possible.
Dec 15 2023, 5:20 PM
karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Does this need rebasing again (-u was moved)? Otherwise looks good.

Dec 15 2023, 5:09 PM
karels accepted D43071: periodic: Make security diff(1) output as small is possible.

Double-checking the places where this gets used, I don't think context is important. I agree with the long MFC just in case.

Dec 15 2023, 5:04 PM
karels accepted D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.

LGTM too

Dec 15 2023, 4:57 PM
karels added inline comments to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 15 2023, 4:25 AM
karels added inline comments to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 15 2023, 4:16 AM

Dec 14 2023

karels updated the diff for D43011: tmpfs: increase memory reserve to a percent of available memory + swap.

Add sysctls to man page; rename mem_percent sysctl to memory_percent
to be parallel to memory_reserve.

Dec 14 2023, 10:25 PM
karels added a comment to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.

I spent a little time testing ZFS yesterday out of curiosity. With increasing memory pressure, it looked like it downsized the ARC somewhat. As I added files to tmpfs, the free space didn't go down as much as the content added. But ZFS needs management in most cases; the default seems to assume that the box is a ZFS file server (even for local use), and that ZFS owns most of memory. I also limit the ARC manually. But with any substantial competition for memory, the sysadmin really needs to set limits and/or tune. tmpfs can limit use by setting the size explicitly.

Dec 14 2023, 5:24 PM
karels added a comment to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.

This certainly makes things better, but I wonder how it gets along with the other memory pigs, ZFS and bhyve?

Dec 14 2023, 12:43 AM

Dec 13 2023

karels added a reviewer for D43010: tmpfs: enforce size limit on writes when file system size is default: markj.
Dec 13 2023, 1:05 AM
karels added a reviewer for D43011: tmpfs: increase memory reserve to a percent of available memory + swap: markj.
Dec 13 2023, 1:04 AM
karels updated the diff for D43011: tmpfs: increase memory reserve to a percent of available memory + swap.

Address review comments.

Dec 13 2023, 1:03 AM
karels added inline comments to D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 13 2023, 1:02 AM
karels updated the summary of D43010: tmpfs: enforce size limit on writes when file system size is default.
Dec 13 2023, 1:01 AM
karels updated the summary of D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 13 2023, 12:59 AM

Dec 12 2023

karels requested review of D43011: tmpfs: increase memory reserve to a percent of available memory + swap.
Dec 12 2023, 10:50 PM
karels requested review of D43010: tmpfs: enforce size limit on writes when file system size is default.
Dec 12 2023, 10:49 PM
karels added a comment to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.

I wouldn't object to this. Scripts that previously used no options to diff could just use ${daily_diff_flags}.

Dec 12 2023, 8:28 PM
karels added a comment to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.

Re-reading the man page addition, it is probably overly specific even when the scripts are brought into the picture; it makes it sounds like it is every diff invoked by a daily script. Something more accurate would be good, e.g. referring to "some scripts" or something like that.

Dec 12 2023, 7:06 PM
karels added a comment to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.

If we want to MFC anything soon, I prefer this approach. I wouldn't say that the other part should never be MFCed, but I wouldn't do it anytime soon. The daily output may not be easily machine-parseable, but that doesn't mean there aren't people doing it. Going from plain diff to -U 0 shouldn't lose information (whereas -u to -U 0 can, if context means anything). If this change is separate, any of the scripts in the other set could be merged individually, or new scripts could use daily_diff_flags and still be MFCed. Finally, it is good form to split changes into steps when possible.

Dec 12 2023, 3:57 PM

Dec 8 2023

karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.
Dec 8 2023, 1:49 PM

Dec 7 2023

karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Should this contain the periodic.conf* changes? I would have thought they'd be in the other review only, and now I think they conflict.

No, this is correct. The other one is a MFC'able preprequisite, but this might not be backported, it does not apply anything, but just introduces the flag for daily diff. This applies minimal diff flags to all scripts, effectively. This review cannot be merged into main until the other one isn't merged.

Dec 7 2023, 10:51 PM
karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Should this contain the periodic.conf* changes? I would have thought they'd be in the other review only, and now I think they conflict.

Dec 7 2023, 6:50 PM
karels added a comment to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.

This is what I had in mind; let's see what others think.

Dec 7 2023, 6:13 PM

Dec 6 2023

karels added inline comments to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.
Dec 6 2023, 5:28 PM

Dec 5 2023

karels added a comment to D42721: ifconfig: add -D option to print driver name for interface.

I did the MFC to stable/14. However, this does not merge to stable/13, which does not use netlink and is otherwise different. It could be done manually, but I won't do it unless there is a reason to do so.

Dec 5 2023, 4:30 PM
karels committed rG9b8515f71bd4: ifconfig: add -D option to print driver name for interface (authored by karels).
ifconfig: add -D option to print driver name for interface
Dec 5 2023, 4:18 PM
karels added inline comments to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.
Dec 5 2023, 3:06 PM
karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Sorry, apparently parts were interpreted as markdown, but it was the output of diff and diff -u. My point was that -u is not the default, and is more verbose than the default. WIth the current change, it no longer matters.

Alright so this makes sense to you?

Dec 5 2023, 2:06 PM
karels requested changes to D42900: periodic: Make daily diff(1) flags configurable with daily_diff_flags.
Dec 5 2023, 1:18 PM
karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Sorry, apparently parts were interpreted as markdown, but it was the output of diff and diff -u. My point was that -u is not the default, and is more verbose than the default. WIth the current change, it no longer matters.

Dec 5 2023, 1:03 PM

Dec 4 2023

karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

This one won't be MFC'd. But diff(1) without an option will default to -u as far as I can see. This change is intended for 15 only. The introduction of the flag for all branches.

Dec 4 2023, 9:37 PM
karels added a comment to D42762: periodic: Make daily diff(1) output as small is possible.

Looks like this changes behavior by adding -u to the last 3 daily scripts. But I'm not sure why this should be MFCed. Or you could omit daily_diff_flags from /etc/defaults/rc.conf and set defaults in the scripts that currently use -u if the variable hadn't been set.

Dec 4 2023, 7:03 PM
karels accepted D42762: periodic: Make daily diff(1) output as small is possible.

Seems OK. I wouldn't object to -U 1 either, but for most of these things context is probably unimportant.

Dec 4 2023, 5:27 PM

Dec 1 2023

karels accepted D42830: unix/dgram: bump maximum datagram size limit to 8k.

There is just no maxdgram limit at all, AFAIU. And we should do
the same unless anybody has good explanation for such a limit.

Dec 1 2023, 9:02 PM

Nov 29 2023

karels added a comment to D42463: Teach if_smsc to get MAC from bootargs..

Ronald, I think you can commit this. You can put "Approved: karels", although that's implied by the reviewers listing.

Nov 29 2023, 10:47 PM
karels committed R9:a8880997e081: 14.0 relnotes: fix second instance of BIOS/GPT bootcode requirement (authored by karels).
14.0 relnotes: fix second instance of BIOS/GPT bootcode requirement
Nov 29 2023, 10:17 PM
karels closed D42789: 14.0 relnotes: add other cases to bootcode update section.
Nov 29 2023, 5:15 PM
karels committed R9:692cbd956506: 14.0 relnotes: add other cases to bootcode update section (authored by karels).
14.0 relnotes: add other cases to bootcode update section
Nov 29 2023, 5:15 PM
karels added inline comments to D42789: 14.0 relnotes: add other cases to bootcode update section.
Nov 29 2023, 5:02 PM
karels added a comment to D42789: 14.0 relnotes: add other cases to bootcode update section.

@imp, any comments? Does this meet your approval?

Nov 29 2023, 2:01 PM

Nov 28 2023

karels closed D42721: ifconfig: add -D option to print driver name for interface.
Nov 28 2023, 7:49 PM
karels committed rGcd201c090858: ifconfig: add -D option to print driver name for interface (authored by karels).
ifconfig: add -D option to print driver name for interface
Nov 28 2023, 7:49 PM
karels retitled D42721: ifconfig: add -D option to print driver name for interface from ifconfig: add -D option to fetch interface's driver name to ifconfig: add -D option to print driver name for interface.
Nov 28 2023, 7:47 PM
karels added a reviewer for D42789: 14.0 relnotes: add other cases to bootcode update section: carlavilla.
Nov 28 2023, 7:34 PM
karels updated the diff for D42789: 14.0 relnotes: add other cases to bootcode update section.

Add warning for BIOS+GPT.

Nov 28 2023, 7:31 PM
karels requested review of D42789: 14.0 relnotes: add other cases to bootcode update section.
Nov 28 2023, 6:36 PM

Nov 27 2023

karels added a comment to D42721: ifconfig: add -D option to print driver name for interface.

With the input so far, my inclination is to stay with -D rather than printing the driver name (and unit) by default. I made one small change, which is to print the driver name with -v or -D, so -v is fully verbose.

Nov 27 2023, 10:58 PM
karels updated the diff for D42721: ifconfig: add -D option to print driver name for interface.

Print driver name with -v as well as -D. May as well be fully verbose.

Nov 27 2023, 10:56 PM
karels committed rG1a7c9e1585dd: pwait.1: add missing prompt and command in examples (authored by karels).
pwait.1: add missing prompt and command in examples
Nov 27 2023, 5:00 PM