Page MenuHomeFreeBSD
Differential D43071

periodic: Make security diff(1) output as small is possible
ClosedPublic
Actions

Authored by michaelo on Dec 15 2023, 2:30 PM.
Tags
None
Referenced Files
F132363455: D43071.id131470.diff
Thu, Oct 16, 6:09 AM
F132363441: D43071.id132030.diff
Thu, Oct 16, 6:08 AM
F132363410: D43071.id.diff
Thu, Oct 16, 6:08 AM
F132310459: D43071.diff
Wed, Oct 15, 6:50 PM
Unknown Object (File)
Sat, Sep 20, 1:11 PM
Unknown Object (File)
Sat, Sep 20, 2:02 AM
Unknown Object (File)
Sat, Sep 20, 1:58 AM
Unknown Object (File)
Sat, Sep 20, 1:03 AM
View All 89 Files
Subscribers
guest-patmaddox
imp

Details

Reviewers
jrm
otis
emaste
• karels
netchild
Commits
rG6d9195b5f763: periodic: Make security diff(1) output as small is possible
rG538994626b9f: periodic: Make security diff(1) output as small is possible
rG3aa71ea7c231: periodic: Make security diff(1) output as small is possible
Summary

Make, by default, security diff(1) produce a unified output with a context of
zero (0) lines. This reduces output of unrelated lines in e-mails delivered
to root.

PR: 270266
Approved by: jrm (mentor), emaste, karels
MFC after: 1 month
Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.Dec 15 2023, 2:30 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 15 2023, 2:30 PM
michaelo requested review of this revision.Dec 15 2023, 2:30 PM
Harbormaster completed remote builds in B54961: Diff 131470.Dec 15 2023, 2:30 PM
michaelo added a comment.Dec 15 2023, 2:31 PM

As requested by @karels, this is now a separate review, with target MFC after one month.

• karels accepted this revision.Dec 15 2023, 5:04 PM

Double-checking the places where this gets used, I don't think context is important. I agree with the long MFC just in case.

This revision is now accepted and ready to land.Dec 15 2023, 5:04 PM
jrm accepted this revision.Dec 15 2023, 5:13 PM
guest-patmaddox added a subscriber: guest-patmaddox.Dec 16 2023, 12:26 PM
Closed by commit rG3aa71ea7c231: periodic: Make security diff(1) output as small is possible (authored by michaelo). · Explain WhyDec 31 2023, 10:18 AM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: rG3aa71ea7c231: periodic: Make security diff(1) output as small is possible.
michaelo added a commit: rG538994626b9f: periodic: Make security diff(1) output as small is possible.Jan 30 2024, 11:43 AM
michaelo added a commit: rG6d9195b5f763: periodic: Make security diff(1) output as small is possible.

Revision Contents
Changeset List

PathSize
share/
man/
man5/
5 lines
usr.sbin/
periodic/
2 lines

Diff 132030

View Options

share/man/man5/periodic.conf.5

Loading...
View Options

usr.sbin/periodic/periodic.conf

Loading...