A few minor additions and clarifications, mostly tags.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 22 2020
Also ready for commit, thanks!
The DocBook parts look good to me.
Mar 19 2020
Mar 18 2020
Yes, that's better. We'll use this version for now and can improve it later if necessary.
OK, we're getting there. Just one sentence that needs the be extended a bit and we're good.
Good to go! Thank you.
A few comments, but I'm generally glad this gets added to the handbook.
Two comments.
Ready to go!
Haha, now no one will approve it, because they don't want to be seen as bored. ;-)
Just kidding, it looks good, so go ahead.
Thanks for that change, it's good to make it. Here is how you can build the website: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/the-website-build.html
Mar 17 2020
Who am I to stand in the way of a good unit conversion example? ;)
Go ahead with the commit! Thanks.
Mar 16 2020
Thank you for these changes. You can commit them now.
Adding Björn for the German translation project for review.
Mar 15 2020
A great addition to have. I've provided a few corrections and clarifications.
Mar 14 2020
I'm not a ports developer, but the changes look sane enough for me.
Nice, ready to commit!
Thank you.
Mar 13 2020
I can't say much about non-doc changes. I'd add the original author of the commit to HEAD as reviewer and ask for approval. I guess they would be happy that you are doing the MFC for them.
Just skip it.
Looks good, ready to go!
Looks good. You don't necessarily need to specify which branch you are planning to MFC to.
It's not wrong either.
Officially accept it, Phabricator won't let me in my last comment.
Mar 12 2020
Thank you, commit approved!
Didn't the original commit to HEAD bump the .Dd? You need to make the change there first, not in stable.
No bump of .Dd? Ah well, you can do that in a separate commit after.
Looking good in general, just replaced a few will-future with simple present.
Mar 10 2020
Approved for commit. Thanks!
Mar 9 2020
Thanks for the update, commit approved!
Mar 8 2020
You're welcome. Go ahead with the commit.
Mar 7 2020
Ah, it's high time that these settings get documented. Thanks for that.
I've added a few corrections and clarifications.
Mar 6 2020
I think it is good to go, we can flesh it out further in a followup commit if need be.
Mar 5 2020
It does look right. Just make sure that you commit the directory, not the file itself directly. Otherwise, you'll lose the mergeinfo.
Mar 3 2020
OK from manpages.
Mar 1 2020
Good to go!
Good to go!
Thanks for taking care of it.
Two fixes, then you can commit it.
Feb 29 2020
Looks good, ready to commit.
Feb 27 2020
Approved then! Thank you.
Looks good so far, just two more commas to add.
We would have to sweep the handbook for more such examples to either add more such notes or change the instructions to be written for /bin/sh.
Feb 26 2020
OK from manpages.
Ready for commit. Thanks!
Feb 25 2020
Hi mentees, can you commit this and do the MFC after a couple of days? Thanks!
Feb 24 2020
I found a few things, but having this in the porters handbook is good.
Feb 22 2020
Good that PC98 is gone from the handbook, too. Make it so!
Cool, go ahead then!
Manpages is also good with this change. Thanks for implementing it.
I like this change, but have a few remarks.
Feb 21 2020
Good to go.
Go ahead with the commit then. Thanks!
A small addition, both the kernel and the modules have the debug symbols.
Feb 20 2020
OK then, bless the repo with this change. ;-)
Good catch, looks good to me.
@0mp: Can you commit this and do the MFC (as a mentee training exercise)?
Feb 19 2020
Two fixes, but good addition to the install chapter nevertheless!
Uppercase NIC, the rest of the man page looks good.
Feb 18 2020
Feb 17 2020
I think this looks good now. I will commit it. Thank you!
Feb 15 2020
Looks good. Can one of my mentees take care of committing it, including an MFC?
Feb 13 2020
Manpages is also good with this change. Thanks for the implementation.
Minor man page change. You can run checks on man pages with "mandoc -Tlint" and textproc/igor.
Feb 12 2020
Good to go!
OK from manpages. Don't forget to bump the .Dd in the manpage for this content change.
Feb 10 2020
Good to go!
Missing comma
Feb 9 2020
OK for the manpage changes. The binmiscctl.8 also needs a .Dd bump (content change).
OK from manpages.