Page MenuHomeFreeBSD
Feed Advanced Search

Mar 22 2020

bcr added a comment to D24151: [handbook] Add a section to about switching pkg from the quarterly branch to the latest branch.

A few minor additions and clarifications, mostly tags.

Mar 22 2020, 4:39 PM
bcr accepted D24148: Add HISTORY sections to log(3) man page.

Commit approved!

Mar 22 2020, 11:56 AM
bcr accepted D24147: Add HISTORY section to getc(3) man page.

Good to go!

Mar 22 2020, 11:55 AM
bcr accepted D24146: exit(3) man page: Add HISTORY section.

Also ready for commit, thanks!

Mar 22 2020, 11:53 AM
bcr accepted D24145: exec(3) man page: Add HISTORY section.

Good to go!

Mar 22 2020, 11:53 AM
bcr added a comment to D23816: Porter Handbook: document Uses/cabal.mk.

The DocBook parts look good to me.

Mar 22 2020, 11:52 AM

Mar 19 2020

bcr accepted D24123: [handbook] remove sparc from bsdinstall section.

Approved!

Mar 19 2020, 4:19 PM
bcr committed rD53994: Release Mateusz Piotrowski from mentorship..
Release Mateusz Piotrowski from mentorship.
Mar 19 2020, 9:48 AM

Mar 18 2020

bcr accepted D24116: [handbook] reorganize installation section.

Yes, that's better. We'll use this version for now and can improve it later if necessary.

Mar 18 2020, 6:37 PM
bcr added a comment to D24116: [handbook] reorganize installation section.

OK, we're getting there. Just one sentence that needs the be extended a bit and we're good.

Mar 18 2020, 4:47 PM
bcr accepted D24114: Document geli(8) loader variables conventions.

Good to go! Thank you.

Mar 18 2020, 3:56 PM
bcr added a comment to D24116: [handbook] reorganize installation section.

A few comments, but I'm generally glad this gets added to the handbook.

Mar 18 2020, 3:56 PM
bcr added a comment to D24114: Document geli(8) loader variables conventions.

Two comments.

Mar 18 2020, 3:43 PM
bcr accepted D24112: Document that posixshmcontrol first appeared in 12.1.

Ready to go!

Mar 18 2020, 2:30 PM
bcr accepted D23999: Porter's Handbook: Document CARGO_FEATURES==--no-default-features.

Haha, now no one will approve it, because they don't want to be seen as bored. ;-)
Just kidding, it looks good, so go ahead.

Mar 18 2020, 12:22 PM
bcr requested changes to D24108: website: add disclaimer about AsiaBSDCon 2020.

Thanks for that change, it's good to make it. Here is how you can build the website: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/the-website-build.html

Mar 18 2020, 8:00 AM
bcr accepted D24106: Fix a typo.

Good catch, approved!

Mar 18 2020, 7:56 AM

Mar 17 2020

bcr accepted D24096: Tell the world how to convert gigabytes to bytes with units(1) easily.

Who am I to stand in the way of a good unit conversion example? ;)
Go ahead with the commit! Thanks.

Mar 17 2020, 9:55 AM

Mar 16 2020

bcr committed rD53988: Remove trailing whitespace from line endings in two places..
Remove trailing whitespace from line endings in two places.
Mar 16 2020, 2:38 PM
bcr committed rD53987: To be consistent, add the missing comment for the Set_Highlights().
To be consistent, add the missing comment for the Set_Highlights()
Mar 16 2020, 2:21 PM
bcr accepted D24078: [handbook] bsdinstall update allocation disk section - ZFS.

Thank you for these changes. You can commit them now.

Mar 16 2020, 7:50 AM
bcr added a reviewer for D24080: update java documentation / German translation: bhd.

Adding Björn for the German translation project for review.

Mar 16 2020, 7:50 AM

Mar 15 2020

bcr added a comment to D24078: [handbook] bsdinstall update allocation disk section - ZFS.

A great addition to have. I've provided a few corrections and clarifications.

Mar 15 2020, 6:04 PM
bcr accepted D23598: Translate the bsdl-gpl article in Italian.

I approve!

Mar 15 2020, 2:30 PM

Mar 14 2020

bcr accepted D24069: textproc/docproj: Back itstool dependency to the latest version.

I'm not a ports developer, but the changes look sane enough for me.

Mar 14 2020, 6:46 PM
bcr accepted D24067: [handbook] bsdinstall update allocation disk section - manual.

Nice, ready to commit!
Thank you.

Mar 14 2020, 2:54 PM

Mar 13 2020

bcr accepted D24063: MFC 357638 to stable/12.

Looks good, go ahead!

Mar 13 2020, 1:39 PM
bcr accepted D24060: MFC 354967 to stable/12.

Ready to go!

Mar 13 2020, 1:18 PM
bcr added a comment to D24058: MFC 351481, 357619 to stable/12.

I can't say much about non-doc changes. I'd add the original author of the commit to HEAD as reviewer and ask for approval. I guess they would be happy that you are doing the MFC for them.

Mar 13 2020, 11:14 AM
bcr requested changes to D24056: CMSG_DATA.3: Fix formatting of printf escape sequences.

Just skip it.

Mar 13 2020, 10:49 AM
bcr accepted D24057: MFC r340031, r340032, r340048: Improve SMB documentation.

Looks good, ready to go!

Mar 13 2020, 10:26 AM
bcr accepted D24056: CMSG_DATA.3: Fix formatting of printf escape sequences.

Looks good. You don't necessarily need to specify which branch you are planning to MFC to.
It's not wrong either.

Mar 13 2020, 10:26 AM
bcr accepted D24055: MFC r340001 to stable/12.

Good to go!

Mar 13 2020, 9:57 AM
bcr accepted D24054: MFC 339952 to stable/12.

Go ahead with the commit. Thanks!

Mar 13 2020, 9:35 AM
bcr accepted D24053: MFC 339952 to stable/11.

Approved!

Mar 13 2020, 9:34 AM
bcr accepted D24052: MFC r339957 to stable/12.

Ready for commit. Thanks!

Mar 13 2020, 8:55 AM
bcr accepted D24051: MFC r339957 to stable/11.

Good to go!

Mar 13 2020, 8:55 AM
bcr accepted D24047: MFC r339962 into stable/12.

Officially accept it, Phabricator won't let me in my last comment.

Mar 13 2020, 8:41 AM
bcr requested changes to D24047: MFC r339962 into stable/12.

OK, go ahead then!

Mar 13 2020, 8:40 AM

Mar 12 2020

bcr accepted D24045: [handbook] bsdinstall update allocation disk section.

Thank you, commit approved!

Mar 12 2020, 9:19 PM
bcr added a comment to D24047: MFC r339962 into stable/12.

Didn't the original commit to HEAD bump the .Dd? You need to make the change there first, not in stable.

Mar 12 2020, 9:18 PM
bcr accepted D24048: MFC r339962 into stable/11.

Also good to go.

Mar 12 2020, 9:17 PM
bcr accepted D24047: MFC r339962 into stable/12.

No bump of .Dd? Ah well, you can do that in a separate commit after.

Mar 12 2020, 9:00 PM
bcr added a comment to D24045: [handbook] bsdinstall update allocation disk section.

Looking good in general, just replaced a few will-future with simple present.

Mar 12 2020, 8:51 PM
bcr accepted D24044: MFC 339729.

Good to go. Thanks for the details!

Mar 12 2020, 8:46 PM
bcr accepted D24043: ftw.3: Follow style(9) in the example.

OK, go ahead!

Mar 12 2020, 6:23 PM

Mar 10 2020

bcr accepted D24019: Add serveria to the ISP commercial page.

Approved for commit. Thanks!

Mar 10 2020, 7:38 PM

Mar 9 2020

bcr accepted D24006: [handbook] bsdinstall update ZFS installation image.

Thanks for the update, commit approved!

Mar 9 2020, 8:19 PM

Mar 8 2020

bcr accepted D23996: [handbook] bsdinstall add the hardening section.

You're welcome. Go ahead with the commit.

Mar 8 2020, 10:28 AM

Mar 7 2020

bcr added a comment to D23996: [handbook] bsdinstall add the hardening section.

Ah, it's high time that these settings get documented. Thanks for that.
I've added a few corrections and clarifications.

Mar 7 2020, 9:21 PM

Mar 6 2020

bcr accepted D23851: handbook: clarify that cmd examples use sh syntax.

I think it is good to go, we can flesh it out further in a followup commit if need be.

Mar 6 2020, 6:32 PM

Mar 5 2020

bcr accepted D23976: MFC r339990.

It does look right. Just make sure that you commit the directory, not the file itself directly. Otherwise, you'll lose the mergeinfo.

Mar 5 2020, 7:51 PM
bcr accepted D21750: ftw.3: Add examples.
Mar 5 2020, 9:52 AM

Mar 3 2020

bcr accepted D23941: powerd.8: Improve style & fix typos.

Good to go. Thanks!

Mar 3 2020, 1:05 PM
bcr accepted D23936: thr_self.2: Fix some typos in the thread identifier range.

OK from manpages.

Mar 3 2020, 7:55 AM

Mar 1 2020

bcr accepted D23907: Update https://www.freebsd.org/security/unsupported.html to show 12.0 is EOL.

Good to go!

Mar 1 2020, 5:47 PM
bcr accepted D23585: Include warning about unintended consequences of using the operator account, and add note about GELI passing TRIM/UNMAP requests to ZFS FAQ.

Good to go!
Thanks for taking care of it.

Mar 1 2020, 3:54 PM
bcr accepted D23898: [handbook] bsdinstall update 2.8.4. Enabling Services.

Two fixes, then you can commit it.

Mar 1 2020, 3:49 PM

Feb 29 2020

bcr accepted D23588: Fixes to the bsdl-gpl article.

Good to go!

Feb 29 2020, 4:57 PM
bcr accepted D23890: [handbook] Some minor corrections.

Looks good, ready to commit.

Feb 29 2020, 4:54 PM

Feb 27 2020

bcr accepted D23858: [handbook] bsdinstall update Setting the Time Zone section.

Approved then! Thank you.

Feb 27 2020, 8:22 PM
bcr added a comment to D23858: [handbook] bsdinstall update Setting the Time Zone section.

Looks good so far, just two more commas to add.

Feb 27 2020, 7:37 PM
bcr added a comment to D23851: handbook: clarify that cmd examples use sh syntax.

We would have to sweep the handbook for more such examples to either add more such notes or change the instructions to be written for /bin/sh.

Feb 27 2020, 7:35 PM

Feb 26 2020

bcr accepted D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.

OK from manpages.

Feb 26 2020, 9:56 PM · network
bcr accepted D23845: [handbook] bsdinstall update 2.7. Committing to the Installation.

Ready for commit. Thanks!

Feb 26 2020, 9:56 PM

Feb 25 2020

bcr added reviewers for D23832: Add HISTORY sections to tree(3), stdarg(3) and sigevent(3): 0mp, carlavilla.

Hi mentees, can you commit this and do the MFC after a couple of days? Thanks!

Feb 25 2020, 4:31 PM

Feb 24 2020

bcr committed rD53937: Add a new 2020 section with two articles about the.
Add a new 2020 section with two articles about the
Feb 24 2020, 6:29 PM
bcr added a comment to D23816: Porter Handbook: document Uses/cabal.mk.

I found a few things, but having this in the porters handbook is good.

Feb 24 2020, 6:13 PM

Feb 22 2020

bcr accepted D23800: [handbook] bsdinstall update Figure 2.16. Manually Create Partitions.

Good that PC98 is gone from the handbook, too. Make it so!

Feb 22 2020, 11:40 PM
bcr accepted D23789: [handbook] bsdinstall update 2.6. Allocating Disk Space section.

Cool, go ahead then!

Feb 22 2020, 9:17 PM
bcr accepted D23792: Add 'ctld -t'..

Manpages is also good with this change. Thanks for implementing it.

Feb 22 2020, 8:37 PM
bcr added a comment to D23789: [handbook] bsdinstall update 2.6. Allocating Disk Space section.

I like this change, but have a few remarks.

Feb 22 2020, 8:35 PM

Feb 21 2020

bcr accepted D23786: Upgrade software section.

Approved!

Feb 21 2020, 10:16 PM
bcr accepted D23784: [handbook] bsdinstall update figure 2.9. Installing from the Network.

Good to go.

Feb 21 2020, 7:41 PM
bcr accepted D23781: [handbook] bsdinstall update components.

Go ahead with the commit then. Thanks!

Feb 21 2020, 7:39 PM
bcr added a comment to D23781: [handbook] bsdinstall update components.

A small addition, both the kernel and the modules have the debug symbols.

Feb 21 2020, 1:49 PM
bcr accepted D23780: Hardware section.

OK, ready to ship.

Feb 21 2020, 1:34 PM

Feb 20 2020

bcr accepted D23777: Upgrade hardware section.

Looks good!

Feb 20 2020, 9:10 PM
bcr accepted D23761: [handbook] bsdinstall update part 3.

OK then, bless the repo with this change. ;-)

Feb 20 2020, 12:55 PM
bcr accepted D23771: [handbook] Broken link Bibliography NCSTRL.

Approved!

Feb 20 2020, 12:55 PM
bcr accepted D23772: New BSD User Group in Belfast, UK.

Loosk good, good to go.

Feb 20 2020, 12:54 PM
bcr accepted D23769: Fix broken links sound manuals.

Good catch, looks good to me.
@0mp: Can you commit this and do the MFC (as a mentee training exercise)?

Feb 20 2020, 8:56 AM

Feb 19 2020

bcr added a comment to D23761: [handbook] bsdinstall update part 3.

Two fixes, but good addition to the install chapter nevertheless!

Feb 19 2020, 9:13 PM
bcr added a comment to D23752: Teach lagg to use rate-limited send tags for lacp.

Uppercase NIC, the rest of the man page looks good.

Feb 19 2020, 10:31 AM

Feb 18 2020

bcr committed rD53914: Add a more specific location of the EuroBSDcon 2020 venue.
Add a more specific location of the EuroBSDcon 2020 venue
Feb 18 2020, 6:10 PM
bcr accepted D23739: libfetch: add support for keep-alive.

OK from manpages.

Feb 18 2020, 9:47 AM

Feb 17 2020

bcr committed rD53911: - Simplify multiple sentences to remove the words: furthermore, also, ....
- Simplify multiple sentences to remove the words: furthermore, also, ...
Feb 17 2020, 6:36 PM
bcr closed D23426: Simplify IPFW in-kernel NAT section (handbook).
Feb 17 2020, 6:36 PM
bcr accepted D23426: Simplify IPFW in-kernel NAT section (handbook).

I think this looks good now. I will commit it. Thank you!

Feb 17 2020, 6:16 PM

Feb 15 2020

bcr added reviewers for D23693: Add some HISTORY sections to manpages: 0mp, carlavilla.

Looks good. Can one of my mentees take care of committing it, including an MFC?

Feb 15 2020, 10:20 AM

Feb 13 2020

bcr accepted D23461: netgraph: Add RFC 6598/Carrier Grade NAT support to ng_nat.

Manpages is also good with this change. Thanks for the implementation.

Feb 13 2020, 8:10 AM · network
bcr added a comment to D23450: libalias: Allow setting alias port ranges.

Minor man page change. You can run checks on man pages with "mandoc -Tlint" and textproc/igor.

Feb 13 2020, 8:09 AM

Feb 12 2020

bcr accepted D23642: diff.1: Fix style & document -y as extension to POSIX.

Good to go!

Feb 12 2020, 7:04 PM
bcr accepted D23597: Respect PATH from login.conf in cron..

OK from manpages. Don't forget to bump the .Dd in the manpage for this content change.

Feb 12 2020, 9:12 AM

Feb 10 2020

bcr accepted D23609: [handbook] bsdinstall update part 2.

Thanks, ready to go!

Feb 10 2020, 8:31 PM
bcr accepted D23613: [handbook] Addition to section 31.4. USB Tethering.

Good to go!

Feb 10 2020, 8:31 PM
bcr added a comment to D23609: [handbook] bsdinstall update part 2.

Missing comma

Feb 10 2020, 7:46 PM
bcr accepted D23606: handbook: fix example for vlan.

Approved!

Feb 10 2020, 5:47 PM

Feb 9 2020

bcr accepted D23593: Remove sparc64 stuff from usr.sbin.

OK for the manpage changes. The binmiscctl.8 also needs a .Dd bump (content change).

Feb 9 2020, 8:14 PM
bcr accepted D23586: ipfw_nat: Perfomance of accessing multiple nat tables.

OK from manpages.

Feb 9 2020, 10:48 AM