DRAFT: ng_ksocket: IPv6 address parsing and unparsing

[nc]

Summary

Add IPv6 support to address parsing and unparsing to ng_ksocket.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Keep in mind that this is a DRAFT. Things still need to be done, including:

• Fix the "ngctl: send msg: Invalid argument" error - I don't know where this fails or if I am doing something wrong.
• Anything more commenters want

Test Plan

Do something like this:

1. ngctl

+ mkpeer ksocket myhook2 inet6/stream/tcp6
+ msg .:myhook2 connect inet6/[::1]:22

The above does not work, see the summary for more details.

[nc]

Remove testing printfs.

[hrs]

sys/netgraph/ng_ksocket.c

328

inet_pton in libkern should be used to parse an IPv6 address. Also, you should consider to support a link-local address with an interface identifier such as [fe80::1%em0]:80.

421

Please use inet_ntop(). And sin6->sin6_scope_id must not be ignored. The in-kernel representation of an link-local address has embedded scope zone id inside the address itself, so you might want to double-check the scope and value of sin6_addr.s6_addr16[1] in both cases of ntop and pton.

[nc]

Here, I use inet_pton and inet_ntop. I didn't know this was possible in the kernel, so that's why the first revision lacked this.

I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong?

[nc]

Let's include a man page.

[bcr]

OK from manpages.

[glebius]

In D23788#523247, @neel_neelc.org wrote:

I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong?

Well, you've added 3 new places that could return EINVAL. Could it be that one of them fires? Of course there are more places in netgraph that can return EINVAL, but first makes sense to isolate that this isn't new code.

[nc]

I forgot a "return(0)" in the IPv6 unparsing.

This does not solve the "Invalid argument" errors. However, the issue is not with my code. I tried printfs in the same statements as the EINVAL returns and got nothing.

Something else must be causing this in the ng_ksocket or its dependents.