- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 9 2017
Nov 8 2017
Nov 7 2017
Committed in r325516.
In D12972#269385, @mjg wrote:For consistency this should also remove SLOCK/SUNLOCK in the lookup case, otherwise LGTM.
Mind adding testing instructions?
LGTM.
Nov 5 2017
Minor changes requested.
Nov 3 2017
Oct 31 2017
Oct 29 2017
Guys, since there was a discussion over how the patch does what it does, can I get one more approval before I commit this, Just In Case™?
Oct 27 2017
Any update on that? Should it be accepted or rejected?
Oct 26 2017
Oct 25 2017
Oct 5 2017
Sep 28 2017
Sep 14 2017
Sep 11 2017
Aug 17 2017
Aug 15 2017
Aug 6 2017
Jul 25 2017
Jul 21 2017
Jul 13 2017
LGTM, however, the vuxml url doesn't work.
Jul 7 2017
Other than the COMMENT comment ;) it looks good to me.
Jul 6 2017
Jul 5 2017
Jul 1 2017
Link to the build logs seems to be broken?
Jun 29 2017
LGTM, however, in the commit msg, please refrain from too 'chilled out' comments, instead of:
Jun 28 2017
Update the stack guard option to new sysctl behaviour.
Jun 27 2017
Can you try with gcc to check if the problem is with clang or somewhere else?
Jun 26 2017
The reports of my death are greatly exaggerated. LGTM.
Jun 6 2017
@allanjude What are we going to do about this? Is bsdinstall change acceptable to you, or would you want me to create a patch for ttys instead? I'd like it to land already.
Jun 4 2017
Jun 2 2017
Can you provide links to your Poudriere build logs? Do so with every patch that requires build tests.
Regarding the commit message:
You can close it now. Use arc for it :)
LGTM.
I'd still like to see the templated commit message.
May 31 2017
Can you please paste complete commit message you'd use (with the templating) with every revision you create for a review?
May 26 2017
Apr 22 2017
Apr 12 2017
Apr 9 2017
Apr 7 2017
Apr 6 2017
Apr 5 2017
Apr 3 2017
Apr 1 2017
Mar 31 2017
@allanjude @bapt @nwhitehorn @adrian @emaste Any updates, please?