Page MenuHomeFreeBSD

www/node: Update 8.1.2 -> 8.1.3
ClosedPublic

Authored by bhughes on Jun 29 2017, 8:30 AM.

Details

Summary

www/node: Update 8.1.2 -> 8.1.3

  • Pet portlint (trailing whitespace)

Approved by: robak (mentor)

Test Plan

$ pwd
/usr/ports/www/node
$ portlint -C
WARN: Makefile: [0]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
0 fatal errors and 2 warnings found.

http://35.176.84.170/data/latest-per-pkg/node/8.1.3/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bhughes created this revision.Jun 29 2017, 8:30 AM
robak accepted this revision.Jun 29 2017, 10:26 AM

LGTM, however, in the commit msg, please refrain from too 'chilled out' comments, instead of:

www/node: Update 8.1.2 -> 8.1.3

Update to the latest upstream release. While here, pet portlint.

Approved by:	robak (mentor)

you could do:

www/node: Update 8.1.2 -> 8.1.3

- Pet portlint

Approved by:	robak (mentor)

The first part below the commit msg subject is a repetition of the subject.

This revision is now accepted and ready to land.Jun 29 2017, 10:26 AM
bhughes edited the summary of this revision. (Show Details)Jun 29 2017, 10:40 AM
This revision was automatically updated to reflect the committed changes.