www/node: Update 8.1.2 -> 8.1.3
- Pet portlint (trailing whitespace)
Approved by: robak (mentor)
Details
Details
- Reviewers
robak mat - Commits
- rP444641: www/node: Update 8.1.2 -> 8.1.3
$ pwd
/usr/ports/www/node
$ portlint -C
WARN: Makefile: [0]: possible direct use of command "python" found. use ${PYTHON_CMD} instead.
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
0 fatal errors and 2 warnings found.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
LGTM, however, in the commit msg, please refrain from too 'chilled out' comments, instead of:
www/node: Update 8.1.2 -> 8.1.3 Update to the latest upstream release. While here, pet portlint. Approved by: robak (mentor)
you could do:
www/node: Update 8.1.2 -> 8.1.3 - Pet portlint Approved by: robak (mentor)
The first part below the commit msg subject is a repetition of the subject.