Page MenuHomeFreeBSD

www/node: Update 8.8.1 -> 9.0.0
ClosedPublic

Authored by bhughes on Nov 6 2017, 2:23 PM.

Details

Summary

www/node: Update 8.8.1 -> 9.0.0

Update to the latest major version of Node.js.

https://nodejs.org/en/blog/release/v9.0.0/

Test Plan

$ pwd
/usr/ports/www/node
$ portlint -C
WARN: Makefile: possible use of absolute pathname "/etc/make.conf".
WARN: Makefile: "IGNORE" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
0 fatal errors and 3 warnings found.

http://35.176.84.170/data/latest-per-pkg/node/9.0.0/

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bhughes created this revision.Nov 6 2017, 2:23 PM

This needs an UPDATING entry as well.

bhughes updated this revision to Diff 34862.Nov 6 2017, 7:05 PM

Add an UPDATING entry on how to stay on Node.js v8.x LTS

robak requested changes to this revision.Nov 7 2017, 10:23 AM
robak added inline comments.
UPDATING
17 ↗(On Diff #34862)

Would that uninstall existing www/node installation? We've CONFLICT entries there now.

www/node/Makefile
10 ↗(On Diff #34862)

Version number missing (like in all other node ports)? I'm thinking about coherent COMMENT between all these ports.

This revision now requires changes to proceed.Nov 7 2017, 10:23 AM
bhughes added inline comments.Nov 7 2017, 12:03 PM
UPDATING
17 ↗(On Diff #34862)

Yes, it would. For example:

# pkg install node6
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
All repositories are up to date.
Checking integrity... done (1 conflicting)
  - node6-6.11.5 conflicts with node-8.8.1 on /usr/local/bin/node
Checking integrity... done (0 conflicting)
The following 2 package(s) will be affected (of 0 checked):

Installed packages to be REMOVED:
	node-8.8.1

New packages to be INSTALLED:
	node6: 6.11.5

Number of packages to be removed: 1
Number of packages to be installed: 1

The operation will free 3 MiB.

Proceed with this action? [y/N]:
www/node/Makefile
10 ↗(On Diff #34862)

Does the version number need to be duplicated? I see the value in explicitly identifying the LTS release lines, but this isn't an LTS release.

robak accepted this revision.Nov 7 2017, 2:03 PM

LGTM.

This revision is now accepted and ready to land.Nov 7 2017, 2:03 PM
Harbormaster completed remote builds in B12519: Diff 34862.
This revision was automatically updated to reflect the committed changes.