In D10232#213091, @allanjude wrote:

Can you tell me a bit more about the testing you have done on this, and what remains to be done?

Maybe we can get Andrew Turner to try net booting an ARM64 machine with this.

good catch:)

LGTM.

In D9547#213027, @Mikhail.Kupchik_gmail.com wrote:

What is the current status of this work?

I think it's ready. It works in my environment. All feedback from reviews (here and on Illumos) was taken into account and integrated into this patch. Coding style issues were fixed.

In D9547#207910, @Mikhail.Kupchik_gmail.com wrote:

fixed these two style issues

We do not need to restore *ip on bad checksum - the whole packet
will be freed anyhow.

use getsecs() instead of time(0), fix efi getsecs...

Overall seems pretty nice, i think.

EFI should build dev_net.c and link efinet_dev with netdev.

pxe.c needs sys/param.h

use nitems() instead of NENTS()

spelling issue in pxe.h

I think the NQNFS comment is also not actual any more

In D10203#210894, @allanjude wrote:

even just reading the 2nd label is a big improvement. Thank you.

Have you tested this by say clobbering the first label?

In D10198#210891, @allanjude wrote:

Does this change which pool might be booted from if you have more than 1 pool?

How have you tested this change?

svn update.

still missed one space before tab.

And some more cstyle fixes.

missed one more malloc check, and small cstyle fix - missing space after
return keyword.

The review at illumos side: https://www.illumos.org/rb/r/408/

malloc can fail: so the stat size and mode should be zeroed before.
stat can fail: set mode = 0
and free does not need the check, but the comment is helpful.

This work is an result of review in https://www.illumos.org/rb/r/259/

Fixed the dhcp.interface-mtu check.

gcc did complain about missing prototype for getsecs(), including net.h
alone is not enough, so I just did add local prototype. clang does not seem
to care...

Ah, right, there is an problem now with viewing the changes - if you just upload the diff, there is not enough context for phabricator to work with. arcanist does post automatically, diff needs some command line option to provide the whole file, I can not recall it off hand..

Actually hold the horses a bit, I have incoming comments from illumos review and we can get this even better:)

seems ok for me:)

I'm sorry it took so long till I got to this one, some cstyle issues need attention.

whitespace cleanup

Typo in errno name and casting to int.

ptable_print needs to open the nested partition with disk_open,
as the state is not shared any more.

In D9870#206870, @kozlov.sergey.404_gmail.com wrote:

Please let me know if you need another round of testing done to commit this one

Rewrote to use single sector sized bounce buffer. Done for safety reasons,
so we wont attempt to allocate some large buffers due to chaining errors.

typo fixed.

Update suggested by rpokala.

LGTM

svn update; and clean up the inverted if statement.

Fixes suggested by smh.

In D9687#200246, @imp wrote:

All the string functions suffer from the same problem we have with the original string functions you replaced: they don't properly implement character conversions. Please see the efivar stuff I did in -current to see what you need to do there. And you should put the functions I wrote there into libstand. While these functions work well enough for ASCIIish things, they fail for anything more complex. If we're going to rework things, let's do it correctly and reuse what was done correctly for efivar (who, to be fair, stole and reworked the code from Marcel's earlier efi on ia64 work).

In D9520#196965, @gonzo wrote:

I tested it on rpi3, it works with crochet-generated image

OK  lsdev
disk devices:
    disk0:    15564801 X 512 blocks (removable)
      disk0s1: DOS/Windows
      disk0s2: FreeBSD
        disk0s2a: FreeBSD UFS
net devices:
    net0: