loader: ls command should display file types properly

[tsoome]

Summary

With some file system the ls is unable to display file types.

Test Plan

verified zfs, ufs, nfs, dosfs

[allanjude]

sys/boot/common/ls.c

120 ↗

(On Diff #26466)

sb is not used after this, until it is overwritten by the call to stat().

[tsoome]

malloc can fail: so the stat size and mode should be zeroed before.
stat can fail: set mode = 0
and free does not need the check, but the comment is helpful.

[tsoome]

sys/boot/common/ls.c

120 ↗

(On Diff #26466)

something got missing in between... the size and mode need to be zeroed for case we do not get into the stat.

[tsoome]

The review at illumos side: https://www.illumos.org/rb/r/408/

[tsoome]

missed one more malloc check, and small cstyle fix - missing space after
return keyword.

[tsoome]

And some more cstyle fixes.

[tsoome]

still missed one space before tab.

[tsoome]

svn update.

[allanjude]

approved by: allanjude