Page MenuHomeFreeBSD

loader: efipart should check disk size from partition table
ClosedPublic

Authored by tsoome on Mar 30 2017, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 24 2023, 10:23 PM
Unknown Object (File)
Dec 20 2023, 3:07 AM
Unknown Object (File)
Nov 9 2023, 3:16 AM
Unknown Object (File)
Oct 8 2023, 2:10 AM
Unknown Object (File)
Sep 29 2023, 3:08 AM
Unknown Object (File)
Aug 7 2023, 9:35 AM
Subscribers
None

Details

Summary

While testing 32bit UEFI OVMF (which has bug about how the disk size
is presented), I did witness the errors from blkio->ReadBlocks().

It became apparent we can not entirely trust UEFI interfaces either,
so additional checks are needed.

So we use disk_ioctl(DIOCGMEDIASIZE) for disks, with fallback of
Media->LastBlock for other media.

In addition, we need to check if there is media present.

+ small fixes for error printout, and avoiding multiple blk * 512.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:47 PM
This revision was automatically updated to reflect the committed changes.