loader: efipart should check disk size from partition table
ClosedPublic
Actions

Authored by tsoome on Mar 30 2017, 11:38 AM.

Tags

None

Referenced Files

	F154134839: D10197.diff
	Sun, Apr 26, 11:19 AM

	Unknown Object (File)
	Sat, Apr 25, 7:32 AM

	Unknown Object (File)
	Sat, Apr 18, 12:49 PM

	Unknown Object (File)
	Fri, Apr 17, 5:28 AM

	Unknown Object (File)
	Thu, Apr 16, 7:30 AM

	Unknown Object (File)
	Mon, Apr 13, 6:09 AM

	Unknown Object (File)
	Wed, Apr 8, 9:31 AM

	Unknown Object (File)
	Mon, Apr 6, 10:01 PM

View All 89 Files

Subscribers

None

Details

Reviewers

allanjude
imp

Commits

rS316279: loader: efipart should check disk size from partition table

Summary

While testing 32bit UEFI OVMF (which has bug about how the disk size
is presented), I did witness the errors from blkio->ReadBlocks().

It became apparent we can not entirely trust UEFI interfaces either,
so additional checks are needed.

So we use disk_ioctl(DIOCGMEDIASIZE) for disks, with fallback of
Media->LastBlock for other media.

In addition, we need to check if there is media present.

+ small fixes for error printout, and avoiding multiple blk * 512.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Mar 30 2017, 11:38 AM

Harbormaster completed remote builds in B8388: Diff 26816.Mar 30 2017, 11:38 AM

Approved By: allanjude

This revision is now accepted and ready to land.Mar 30 2017, 3:47 PM

Closed by commit rS316279: loader: efipart should check disk size from partition table (authored by tsoome). · Explain WhyMar 30 2017, 4:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

efipart.c

37 lines

Diff 26832

View Options

head/sys/boot/efi/libefi/efipart.c

loader: efipart should check disk size from partition tableClosedPublicActions