Page MenuHomeFreeBSD

loader: efipart should check disk size from partition table
ClosedPublic

Authored by tsoome on Mar 30 2017, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jul 28 2025, 5:39 PM
Unknown Object (File)
Jul 12 2025, 2:27 PM
Unknown Object (File)
Jul 10 2025, 4:59 PM
Unknown Object (File)
Jul 5 2025, 9:33 AM
Unknown Object (File)
Jul 4 2025, 5:17 AM
Unknown Object (File)
Apr 23 2025, 7:45 AM
Unknown Object (File)
Apr 14 2025, 8:54 AM
Unknown Object (File)
Apr 14 2025, 4:04 AM
Subscribers
None

Details

Summary

While testing 32bit UEFI OVMF (which has bug about how the disk size
is presented), I did witness the errors from blkio->ReadBlocks().

It became apparent we can not entirely trust UEFI interfaces either,
so additional checks are needed.

So we use disk_ioctl(DIOCGMEDIASIZE) for disks, with fallback of
Media->LastBlock for other media.

In addition, we need to check if there is media present.

+ small fixes for error printout, and avoiding multiple blk * 512.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 30 2017, 3:47 PM
This revision was automatically updated to reflect the committed changes.