Page MenuHomeFreeBSD

loader: implement MEDIA_FILEPATH_DP support in efipart
ClosedPublic

Authored by tsoome on Feb 10 2017, 10:23 AM.

Details

Summary

The efipart rework did break the ARM systems as the new code is
using more exact filters to sort the devices and we need to
add support for MEDIA_FILEPATH_DP device paths.

Test Plan

Need to verify on ARM platform.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tsoome retitled this revision from to loader: implement MEDIA_FILEPATH_DP support in efipart.Feb 10 2017, 10:23 AM
tsoome updated this object.
tsoome edited the test plan for this revision. (Show Details)
tsoome added reviewers: allanjude, imp.
tsoome updated this revision to Diff 24959.
allanjude edited edge metadata.Feb 10 2017, 4:35 PM
allanjude accepted this revision.

Once you get someone to verify this works on an ARM device, approved.

This revision is now accepted and ready to land.Feb 10 2017, 4:35 PM

Once you get someone to verify this works on an ARM device, approved.

It actually does need some more work - while device mapping appears to be OK, there is still something about mapping device path from image handle. Meaning, this snippet is not yet full fix.

gonzo added a subscriber: gonzo.Feb 10 2017, 7:34 PM

I tested it on rpi3, it works with crochet-generated image

OK  lsdev
disk devices:
    disk0:    15564801 X 512 blocks (removable)
      disk0s1: DOS/Windows
      disk0s2: FreeBSD
        disk0s2a: FreeBSD UFS
net devices:
    net0:
In D9520#196965, @gonzo wrote:

I tested it on rpi3, it works with crochet-generated image

OK  lsdev
disk devices:
    disk0:    15564801 X 512 blocks (removable)
      disk0s1: DOS/Windows
      disk0s2: FreeBSD
        disk0s2a: FreeBSD UFS
net devices:
    net0:

does it actually boot properly in your case?

gonzo added a comment.Feb 10 2017, 7:37 PM
In D9520#196965, @gonzo wrote:

I tested it on rpi3, it works with crochet-generated image

... skipped ...

does it actually boot properly in your case?

Yes, it boots to login prompt

manu added a reviewer: manu.Feb 10 2017, 7:50 PM
manu accepted this revision.
manu added a subscriber: manu.

As I said on IRC on #bsdmips I don't know if u-boot is doing the right thing on disk (and by u-boot I mean me since I've done the patch for logical partition).
But it used to work before so if one commit broke it and this review restore the func I'm up for it.
Note that I didn't test the patch. It just looks sane for me.

This revision was automatically updated to reflect the committed changes.