loader: narrow the scope of gfx frame buffer wrt tg supported kernels
ClosedPublic
Actions

Authored by imp on Dec 14 2021, 5:16 AM.

Details

Reviewers

manu
kevans
tsoome

Group Reviewers

Loader

Commits

rGa21fc0475e2b: loader: narrow the scope of gfx frame buffer wrt tg supported kernels
rGaaaa5a2e68e2: loader: narrow the scope of gfx frame buffer wrt tg supported kernels

Summary

Store whether or not we found a vbefb module (eg, a tg supported kernel)
in the preloaded_file structure. This automatically resets on reload and
eliminates load_elf knowing about any gfx_* interface. Restrict this to
i386, which is the only place it's used. Update libi386 to check in the
preloaded_file struct. Eliminate this from the teken_gfx
structure. Rewrite the parsing code to be more inline. Check this from
the same place we check for a relocatable amd64 kernel.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43330
Build 40218: arc lint + arc unit

Event Timeline

imp created this revision.Dec 14 2021, 5:16 AM

Herald added a reviewer: manu. · View Herald TranscriptDec 14 2021, 5:16 AM

Herald added a subscriber: dab. · View Herald Transcript

imp requested review of this revision.Dec 14 2021, 5:16 AM

Harbormaster completed remote builds in B43330: Diff 99973.Dec 14 2021, 5:16 AM

imp edited the test plan for this revision. (Show Details)Dec 14 2021, 5:20 AM

imp added reviewers: Loader, kevans, tsoome.

That looks ok but do we really only support vbe for i386 ?
Doesn't some amd64 hardware that doesn't have EFI (or booted without EFI support) could use vbe ?

In D33427#755741, @manu wrote:

That looks ok but do we really only support vbe for i386 ?
Doesn't some amd64 hardware that doesn't have EFI (or booted without EFI support) could use vbe ?

Yes. However, i386 is used to boot both amd64 and i386 kernels, so we only need vbe on i386.

manu accepted this revision.Dec 14 2021, 8:37 PM

This revision is now accepted and ready to land.Dec 14 2021, 8:37 PM

tsoome accepted this revision.Dec 14 2021, 8:51 PM

Closed by commit rGaaaa5a2e68e2: loader: narrow the scope of gfx frame buffer wrt tg supported kernels (authored by imp). · Explain WhyDec 14 2021, 10:28 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaaaa5a2e68e2: loader: narrow the scope of gfx frame buffer wrt tg supported kernels.

imp added a commit: rGa21fc0475e2b: loader: narrow the scope of gfx frame buffer wrt tg supported kernels.Jan 24 2023, 10:13 PM