Page MenuHomeFreeBSD
Differential D33153

Makefile.inc1: Silence an error in make packages
ClosedPublic
Actions

Authored by otis on Nov 28 2021, 9:00 PM.
Tags
None
Referenced Files
F166857518: D33153.id99214.diff
Mon, Aug 17, 4:46 AM
Unknown Object (File)
Thu, Aug 13, 1:15 AM
Unknown Object (File)
Sat, Aug 8, 4:20 PM
Unknown Object (File)
Mon, Aug 3, 7:43 AM
Unknown Object (File)
Mon, Aug 3, 4:54 AM
Unknown Object (File)
Tue, Jul 28, 6:48 AM
Unknown Object (File)
Sun, Jul 26, 9:33 AM
Unknown Object (File)
Wed, Jul 22, 11:58 PM
View All Files
Subscribers
emaste
imp
Contributor Reviews (src)

Details

Reviewers
emaste
Group Reviewers
Contributor Reviews (src)
Commits
rGae39c0b6bc37: Makefile.inc1: Silence an error in make packages
rGaaa4cd7f3c93: Makefile.inc1: Silence an error in make packages
Summary

When on a system without system without subversion installed,
make packages reported an error like:

eval: /usr/src: Permission denied

This commit tries to fix that.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43015
Build 39903: arc lint + arc unit

Event Timeline

otis created this revision.Nov 28 2021, 9:00 PM
Herald added subscribers: Contributor Reviews (src), emaste, imp. · View Herald TranscriptNov 28 2021, 9:00 PM
otis requested review of this revision.Nov 28 2021, 9:00 PM
Harbormaster completed remote builds in B43015: Diff 99117.Nov 28 2021, 9:00 PM
otis added a reviewer: Contributor Reviews (src).Nov 28 2021, 9:26 PM
imp added a comment.Nov 29 2021, 8:57 PM

How does this compare with https://reviews.freebsd.org/D30990 which is similar. Same problem?

emaste accepted this revision.Nov 29 2021, 9:29 PM

svnversion etc. serves no purpose in main any longer so this whole section should be reworked, but I think this change is fine for now (it doesn't make anything worse) and can be MFC'd.

This revision is now accepted and ready to land.Nov 29 2021, 9:29 PM
Closed by commit rGaaa4cd7f3c93: Makefile.inc1: Silence an error in make packages (authored by otis). · Explain WhyNov 30 2021, 8:57 AM
This revision was automatically updated to reflect the committed changes.
otis added a commit: rGaaa4cd7f3c93: Makefile.inc1: Silence an error in make packages.
otis added a commit: rGae39c0b6bc37: Makefile.inc1: Silence an error in make packages.Dec 7 2021, 7:46 AM

Revision Contents
Changeset List

PathSize
4 lines

Diff 99117

View Options

Makefile.inc1

Loading...